Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate iOS 9 in readme #27670

Closed
wants to merge 1 commit into from
Closed

Deprecate iOS 9 in readme #27670

wants to merge 1 commit into from

Conversation

sunnylqm
Copy link
Contributor

@sunnylqm sunnylqm commented Jan 4, 2020

Summary

Changelog

[CATEGORY] [TYPE] - Message

Test Plan

@sunnylqm sunnylqm requested review from cpojer and hramos as code owners January 4, 2020 03:26
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 4, 2020
@pull-bot
Copy link

pull-bot commented Jan 4, 2020

Messages
📖

📋 Verify Changelog Format - A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

CATEGORY may be:
  • General
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)

TYPE may be:

  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.

MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.

Generated by 🚫 dangerJS against 6f2bd28

@react-native-bot react-native-bot added the Platform: iOS iOS applications. label Jan 4, 2020
cpojer
cpojer approved these changes Jan 7, 2020
View reviewed changes
Copy link
Contributor

@cpojer cpojer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

facebook-github-bot
facebook-github-bot approved these changes Jan 7, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @sunnylqm in d126507.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Jan 7, 2020
@sunnylqm sunnylqm deleted the patch-31 branch January 7, 2020 05:52
osdnk pushed a commit to osdnk/react-native that referenced this pull request Mar 9, 2020
@sunnylqm @osdnk
Deprecate iOS 9 in readme (facebook#27670)
9992abe 
Summary:
## Changelog

[CATEGORY] [TYPE] - Message
Pull Request resolved: facebook#27670

Differential Revision: D19296782

Pulled By: cpojer

fbshipit-source-id: 7a0b5fc1e6bfa5b4b34ceeeefe41e1f902278a0c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot approved these changes

@cpojer cpojer cpojer approved these changes

@hramos hramos Awaiting requested review from hramos

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Platform: iOS iOS applications.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sunnylqm @pull-bot @react-native-bot @cpojer @facebook-github-bot