Make Vibration.vibrate compatible with TurboModules

[brunobar79]

Summary

This PR fixes a compatibility issue with the Vibration module and TurboModules.
The TurboModules spec doesn't allow nullable arguments of type Number, causing the following problem:

Changelog

[iOS] [Fixed] - Make Vibration library compatible with TurboModules.

Test Plan

Just submitted a PR to my own app to fix the issue here

The problem should be reproducible on RNTester due to this line:

react-native/RNTester/js/examples/Vibration/VibrationExample.js

Line 66 in 91f139b

onPress={() => Vibration.vibrate()}>

and should be working on this branch.

[hramos]

This is a great PR. Thanks for fixing this!

[facebook-github-bot]

@hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[hramos]

Ran into some issues landing this, which only surfaced internally due to TurboModules not being fully supported in open source yet.

1. Had to regenerate the native Java spec for the Vibration TurboModule, since the JS spec changed. There's currently no way to run this codegen in open source, but we're working on it.
2. In turn, this surfaced the following error, related to the generated method signatures having changed on Android:

stderr: ReactAndroid/src/main/java/com/facebook/react/modules/vibration/VibrationModule.java:20: error: com.facebook.react.modules.vibration.VibrationModule is not abstract and does not override abstract method vibrate(double) in com.facebook.fbreact.specs.NativeVibrationSpec
public class VibrationModule extends NativeVibrationSpec {
       ^
ReactAndroid/src/main/java/com/facebook/react/modules/vibration/VibrationModule.java:33: error: method does not override or implement a method from a supertype
  @Override
  ^

Do you think you can fix that up in your PR?

[brunobar79]

@hramos Sure, np. I'll take a look some time this week.

[alloy]

@brunobar79 bump, if you want this to make it into v0.62.0-rc.3, which we'll cut over the next few days.

[brunobar79]

@hramos Can you give it a try now? If you regenerate the Java Spec it should match.
cc: @alloy

[facebook-github-bot]

@hramos has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[hramos]

Imported, but it ran into some issues. I'll look at this again sometime this week.

[Frans-L]

@hramos The same issue exists on 0.62.0. Is there any schedule when this pr could be merged? :)

[maxencehenneron]

Note: This error only exists on debug builds, it seems to work fine in release mode, for some reasons.. This PR fixes the issue.

[hramos]

This is still on my todo list, and the past month kind of threw things off. I'll try to take another look soon.

[hramos]

We're actively working on landing this change.

[hramos]

This is landing now. Thanks to @TheSavior for helping push this through.

[react-native-bot]

This pull request was successfully merged by @brunobar79 in 3904228.

^{When will my fix make it into a release? | Upcoming Releases}