Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JavaScript][Removed] - Remove leftover Incremental component #28107

Closed
wants to merge 2 commits into from
Closed

[JavaScript][Removed] - Remove leftover Incremental component #28107

wants to merge 2 commits into from

Conversation

venits
Copy link
Contributor

@venits venits commented Feb 18, 2020 •
edited by thymikee
Loading

Summary

1/4 of #28103

Changelog

[JavaScript][Removed] - Remove leftover Incremental component.

Test Plan

In RNTester Incremental component is no longer used so I modified one of existing examples to use it.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 18, 2020
@pull-bot
Copy link

pull-bot commented Feb 18, 2020 •
edited
Loading

Messages
📖

📋 Verify Changelog Format - A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

CATEGORY may be:
  • General
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)

TYPE may be:

  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.

MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.

Generated by 🚫 dangerJS against b1e6a42

@analysis-bot
Copy link

RNTester (Android/hermes/arm64-v8a): 3289088 bytes
RNTester (Android/hermes/armeabi-v7a): 3129344 bytes
RNTester (Android/hermes/x86): 3461120 bytes
RNTester (Android/hermes/x86_64): 3424256 bytes
RNTester (Android/jsc/arm64-v8a): 4446208 bytes
RNTester (Android/jsc/armeabi-v7a): 4268032 bytes
RNTester (Android/jsc/x86): 4358144 bytes
RNTester (Android/jsc/x86_64): 4644864 bytes

@analysis-bot
Copy link

RNTester.app (iOS): 10657792 bytes

thymikee
thymikee reviewed Feb 18, 2020
View reviewed changes
Libraries/Experimental/Incremental.js Outdated
@@ -94,6 +94,11 @@ export type Props = {
};
type State = {doIncrementalRender: boolean, ...};

const IncrementalContext = React.createContext<Context>({
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This component is not a context provider, but a consumer, so there's no need to create a new context here.
@TheSavior I guess this component is used internally at Facebook or it's some dead code that haven't been removed yet. Can you shed some information on the topic? If it can be removed, that's great. If not, we need to get the context from somewhere.

@venits
Copy link
Contributor Author

venits commented Feb 18, 2020

In previous versions of react-native we had components like IncrementalGroup.js. Now with only Incremental component is hard to decide how it should behave.

Here is how it used to look like:
https://github.com/facebook/react-native/tree/2ee11711e0351f695ec1d5e591ac904e5c9187c4/Libraries/Experimental

@thymikee
Copy link
Contributor

Looks like a leftover from 0ef0d31. I assume you're safe to remove it

@venits
Delete Incremental.js
b1e6a42 
Looks like it is a leftover from this commit: facebook@0ef0d31
@analysis-bot
Copy link

RNTester (Android/hermes/arm64-v8a): 3289088 bytes
RNTester (Android/hermes/armeabi-v7a): 3129344 bytes
RNTester (Android/hermes/x86): 3461120 bytes
RNTester (Android/hermes/x86_64): 3424256 bytes
RNTester (Android/jsc/arm64-v8a): 4446208 bytes
RNTester (Android/jsc/armeabi-v7a): 4268032 bytes
RNTester (Android/jsc/x86): 4358144 bytes
RNTester (Android/jsc/x86_64): 4644864 bytes

@thymikee thymikee changed the title Incremental component support for new Context API [JavaScript][Removed] - Remove leftover Incremental component Feb 18, 2020
@analysis-bot
Copy link

RNTester.app (iOS): 10657792 bytes

facebook-github-bot
facebook-github-bot reviewed Feb 18, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TheSavior has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@elicwhite
Copy link
Member

Yeah, this is unused! Yay. Thanks for deleting.

@janicduplessis
Copy link
Contributor

I made a package with this if anyone is interested https://github.com/th3rdwave/react-native-incremental

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @venits in e998002.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Feb 19, 2020
osdnk pushed a commit to osdnk/react-native that referenced this pull request Mar 9, 2020
@venits @osdnk
- Remove leftover Incremental component (facebook#28107)
782e88c 
Summary:
1/4 of facebook#28103

## Changelog

[JavaScript][Removed] - Remove leftover `Incremental` component.
Pull Request resolved: facebook#28107

Test Plan: In RNTester `Incremental` component is no longer used so I modified one of existing examples to use it.

Reviewed By: rickhanlonii

Differential Revision: D19960536

Pulled By: TheSavior

fbshipit-source-id: 791bda7138ac23916957577ed5f5c465c5e96299
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thymikee thymikee thymikee left review comments

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Type: Removal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@venits @pull-bot @analysis-bot @thymikee @elicwhite @janicduplessis @react-native-bot @facebook-github-bot