Removed core RCTConvert CoreLocation Libraries as well as reference i…

[maschad]

Summary

This PR is to address #28200

Even though GeoLocation was extracted from the Core, there are still libraries i.e. the CoreLocation.h library included which cause Apple to reject Apps, as mentioned here.

This removed all references to the CoreLocation library that where remaining.

Changelog

[iOS] [Removed] - Message

Test Plan

• Flow check passes.
• RNTest built successfully.

[analysis-bot]

RNTester.app (iOS): 10727424 bytes

[facebook-github-bot]

@shergin is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[shergin]

This file is still being used by some deps. One of them (which is blocking landing internally) is this one: https://github.com/react-native-community/react-native-maps/blob/72b0f77e31d18959e91acb036d5f91ab46e11ef2/lib/ios/AirMaps/AIRMapCircleManager.m#L14

I think we should copy the functionally/code there. And then try to remove it from here one more time.

@maschad Can you do it?

[maschad]

Thanks for the recommendation @shergin I re-added them, but my only concern is that Apple's static analyzer may still pick up the CoreLocation files and then trigger a warning.

[shergin]

@maschad Nonono, I meant we need to move/copy those files to that library to break the dependency the core in this regard. After we do that, we can safely remove them from the core.

I will land this one as is. But I would appreciate if you can fix that library and then open another PR that will finally delete the files from the core. 🙏

[facebook-github-bot]

@shergin is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[react-native-bot]

This pull request was successfully merged by @maschad in bcf2a71.

^{When will my fix make it into a release? | Upcoming Releases}

[maschad]

@shergin silly me, I should have realized that 😅. Thanks for clarifying anyways, I can definitely do that 👍🏿