Fix: race condition in android copy vs bundle phases

[glenna]

Summary

We ran into an issue where our index.android.bundle was not included in our generated .aab file (strangely, it was only happening on CI builds). I enabled --info level logging on the gradle command on our CI and noticed that > Task :app:copyPlaystoreReleaseBundledJs NO-SOURCE was there with the info that the source file didn't exist. This led me to believe that the copyXXXBundledJs task and bundleXXXJsAndAssets tasks were not executing in the proper order.

Strangely, this issue only started to occur for us after updating a dependency on Android, but I suspect it's always been a race condition and we've just gotten lucky.

This change ensures that the bundleJsAndAssets task runs before the copyBundledJs task.

I've tested locally with our code and also on our CI and both are finally working 💪

Changelog

[Android] [Fixed] - Ensure gradle task order (bundleJsAndAssets occurs before copyBundledJs)

Test Plan

./gradlew clean && ./gradlew cleanBuildCache && ./gradle bundleFlavourRelease

The generated bundle now includes index.android.bundle (of course this is difficult to test, because the issue only happens on some machines/setups/when the stars align, apparently).

[pull-bot]

Messages

📖

📋 Verify Changelog Format - A changelog entry has the following format: [CATEGORY] [TYPE] - Message. CATEGORY may be: General iOS Android JavaScript Internal (for changes that do not need to be called out in the release notes) TYPE may be: Added, for new features. Changed, for changes in existing functionality. Deprecated, for soon-to-be removed features. Removed, for now removed features. Fixed, for any bug fixes. Security, in case of vulnerabilities. MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.

Generated by 🚫 dangerJS against 834e51e

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
ios	-	universal	829,440	0

Base commit: 40b36a0

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	6,762,671	0
android	hermes	armeabi-v7a	6,425,569	0
android	hermes	x86	7,149,162	0
android	hermes	x86_64	7,039,060	0
android	jsc	arm64-v8a	8,936,042	0
android	jsc	armeabi-v7a	8,591,363	0
android	jsc	x86	8,765,660	0
android	jsc	x86_64	9,341,193	0

Base commit: 40b36a0

[glenna]

This PR is no longer relevant as it's also fixed by: #32026