[Android] Adding Hyphenation Frequency prop for Text component

[fabOnReact]

Summary

This issue fixes #28279
android_hyphenationFrequency prop for Android Text component which sets the frequency of automatic hyphenation to use when determining word breaks.

Changelog

[Android] [Fixed] - Adding Hyphenation Frequency prop for Text component

Test Plan

More info are available in the android docs. I will add the documentation to the docs later once the pull request is taken in consideration for merging.

AFTER

I remain available to do improvements. Thanks a lot. Fabrizio.

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	6,764,177	2,599
android	hermes	armeabi-v7a	6,426,979	2,183
android	hermes	x86	7,150,511	1,794
android	hermes	x86_64	7,040,444	1,748
android	jsc	arm64-v8a	8,937,601	2,633
android	jsc	armeabi-v7a	8,592,787	2,221
android	jsc	x86	8,767,045	1,815
android	jsc	x86_64	9,342,605	1,758

Base commit: e75557b

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
ios	-	universal	829440	n/a

Base commit: e75557b

[elicwhite]

I can't confirm that this will get approved (I don't have context on the Android side), but we've been following a pattern of the platform prefixes being android_, so this prop should be android_hyphenationFrequency. This is also seen in these props on Pressable: https://github.com/facebook/react-native/blob/master/Libraries/Components/Pressable/Pressable.js#L122-L127

[fabOnReact]

thanks a lot @TheSavior . Changes are included in 4500095. I'm fixing the same issue also in #29059. I have no prerogative for the PR to be merged, but just hope to get a better insight in the react-native project and write more relevant pr in the future.. Thanks a lot. Fabrizio

[JoshuaGross]

This seems pretty reasonable to me :)

[facebook-github-bot]

@JoshuaGross has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[JoshuaGross]

@fabriziobertoglio1987 I'm working on testing internally and having some conversations about the prefix. While I'm doing that, could you issue a PR to the docs site to add documentation for the new prop?

https://github.com/facebook/react-native-website/tree/master/docs

[fabOnReact]

UPDATE 30/06/2020

I notice now that 0fda91f does not include the latest changes. Tomorrow I will work on testing this functionality on Android API < 23 and add changes from 14709f8 to master if required (in a separate pull request). Additionally I noticed my errors in #29070. Sorry for this, I did a mistake. I will fix #29070 and not make any errors in my future pull request. Thanks a lot and sorry for disturbing. I understand now that ReactNative Core team is very busy and I should deliver higher quality code.

OLD MESSAGE 26/06/2020

Thanks a lot @JoshuaGross I added the docs and also added a new commit to this Pull Request 14709f8 as setHyphenationFrequency android method is available only from API 23+.

I decided to write this PR as a solution of #28279 to give users more control on the Text Component. I don't work on iOS and I had the impression that textBreakingStrategy was related to breaking paragraphs and sentences (justifying a different prop and setter).

I tested on RNTester example emulator API 28.

#28940 unluckily denies me to test this changes on my API 19 emulator. I am on cellular data right now and can not download another Android 22 image to test the code changes from 14709f8 on devices < Android 23, but I believe the logic will work as the same logic is used with textBreakingStrategy

react-native/ReactAndroid/src/main/java/com/facebook/react/views/text/ReactBaseTextShadowNode.java

Lines 551 to 555 in ce0edca

	@ReactProp(name = ViewProps.TEXT_BREAK_STRATEGY)
	public void setTextBreakStrategy(@Nullable String textBreakStrategy) {
	if (Build.VERSION.SDK_INT < Build.VERSION_CODES.M) {
	return;
	}

I'll work on this and let you know. I remain available. Thanks a lot. I wish you a good day. Fabrizio

[react-native-bot]

This pull request was successfully merged by @fabriziobertoglio1987 in 0fda91f.

^{When will my fix make it into a release? | Upcoming Releases}

[JoshuaGross]

@fabriziobertoglio1987 Thank you for following up on this! The amendment is being merged in.

[fabOnReact]

#29258