Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check android version for TouchableNativeFeedback nativeBackgroundAndroid #29746

Closed
wants to merge 1 commit into from
Closed

Conversation

akgunfu
Copy link

@akgunfu akgunfu commented Aug 24, 2020

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 24, 2020
@pull-bot
Copy link

Messages
📖

📋 Missing Changelog - Can you add a Changelog? To do so, add a "## Changelog" section to your PR description. A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

CATEGORY may be:
  • General
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)

TYPE may be:

  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.

MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.

📖 📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.

Generated by 🚫 dangerJS against 2a36e7e

@akgunfu akgunfu closed this Aug 24, 2020
@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,004,473 -74
android hermes armeabi-v7a 6,668,440 -70
android hermes x86 7,424,806 -58
android hermes x86_64 7,315,686 -59
android jsc arm64-v8a 9,164,370 -10
android jsc armeabi-v7a 8,820,458 4
android jsc x86 9,012,784 14
android jsc x86_64 9,589,866 14

Base commit: 1704a72

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 1704a72

@MarkCSmith
Copy link

@cnkyrpsgl: I do not see this fix on master. Should it have been automatically merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error while updating property 'nativeBackgroundAndroid' of a view managed by: RCTView
6 participants