Change default metro.config.js to utilize inline requires #29770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This Pull request adds the UI changes to the RNTester app as discussed in the MLH Fellowship. ## Changelog This list is not exhaustive. - The initial App screen is redesigned. - A bottom Navbar has been added. - Filter pills are added. - The list card UI is updated. - The example page UI is updated. - Recently Viewed Sections are added. It shows the last 5 recently viewed components/APIs. - Bookmarking functionality is added. - The documentation URL is added to the example page. - RNTester doesn't lose its state on a hard refresh (even on iOS). # Screenshots <img width="373" src="https://user-images.githubusercontent.com/22813027/90530113-20346180-e192-11ea-8ef6-789fa25b402b.png" /> <img width="373" src="https://user-images.githubusercontent.com/22813027/90530112-20346180-e192-11ea-9539-706b540fcc5f.png" /> <img width="373" src="https://user-images.githubusercontent.com/22813027/90530100-1d397100-e192-11ea-8836-b88070643233.png" /> <img width="373" src="https://user-images.githubusercontent.com/22813027/90530110-1f9bcb00-e192-11ea-936b-64ee75fa4289.png" /> Pull Request resolved: facebook#29685 Test Plan: Imported from GitHub, without a `Test Plan:` line. # Tested RNTester in Catalyst {F302717939} # Tested in RNTester in Facebook Note: this failed **before** this diff too: {F302745716} Reviewed By: mdvacca, cpojer Differential Revision: D23240434 fbshipit-source-id: 65e2766a6a097eca0e0d0fda8dadf6871e9276c2
This feature has been in experimental mode since 0.59.0
facebook-github-bot
added
the
CLA Signed
There was a problem hiding this comment.
@TheSavior has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Base commit: 549e5a8 |
Base commit: 549e5a8 |
|
This landed but internal tooling was broken which lost attribution. :( Thanks for contributing! |
elicwhite
referenced
this pull request
Aug 26, 2020
fbshipit-source-id: 65e2766a6a097eca0e0d0fda8dadf6871e9276c2
bigfootjon
pushed a commit
that referenced
this pull request
Aug 26, 2020
Summary: This feature has been in [experimental mode since 0.59.0](https://reactnative.dev/blog/2019/03/12/releasing-react-native-059#-faster-app-launches-with-inline-requires). The feature seems quite beneficial. Most people won't know to look for the inline requires flag, and it's been existing in React Native as an experiment for months. This defaults the flag to true as the next step towards utilizing this optimization for React Native devs initiating brand new projects. ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://github.com/facebook/react-native/wiki/Changelog --> [General] [Breaking] - Enable `inlineRequires` by default. Gives a performance benefit but slightly different JS execution order Pull Request resolved: #29770 Reviewed By: cpojer Differential Revision: D23338113 Pulled By: TheSavior fbshipit-source-id: 1b8ff41418c81a324335782d4b4109d89594ccbf
17 tasks
|
Is there a reason to leave |
36 tasks
The whole think is quite under documented |
This was referenced Mar 13, 2021
Closed
Closed
This was referenced Mar 15, 2021
Closed
Closed
Closed
Closed
Closed
philippeauriach
pushed a commit
to philippeauriach/react-native
that referenced
this pull request
May 5, 2021
…9770) Summary: This feature has been in [experimental mode since 0.59.0](https://reactnative.dev/blog/2019/03/12/releasing-react-native-059#-faster-app-launches-with-inline-requires). The feature seems quite beneficial. Most people won't know to look for the inline requires flag, and it's been existing in React Native as an experiment for months. This defaults the flag to true as the next step towards utilizing this optimization for React Native devs initiating brand new projects. ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://github.com/facebook/react-native/wiki/Changelog --> [General] [Breaking] - Enable `inlineRequires` by default. Gives a performance benefit but slightly different JS execution order Pull Request resolved: facebook#29770 Reviewed By: cpojer Differential Revision: D23338113 Pulled By: TheSavior fbshipit-source-id: 1b8ff41418c81a324335782d4b4109d89594ccbf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This feature has been in experimental mode since 0.59.0. The feature seems quite beneficial.
Most people won't know to look for the inline requires flag, and it's been existing in React Native as an experiment for months. This defaults the flag to true as the next step towards utilizing this optimization for React Native devs initiating brand new projects.
Changelog
[General] [Breaking] - Enable
inlineRequiresby default. Gives a performance benefit but slightly different JS execution order