[iOS] Fix for loading state of Fast Refresh from user defaults #29880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
dmitryn
approved these changes
Sep 7, 2020
stigi
changed the title
Base commit: 902611f |
stigi
force-pushed
the
stigi/hmr-default-fix
branch
from
95dea4f
to
a594047
Compare
stigi
commented
Sep 7, 2020
| @@ -405,17 +405,18 @@ - (void)addHandler:(id<RCTPackagerClientMethod>)handler forPackagerMethod:(NSStr | |||
|
|
|||
| - (void)setupHMRClientWithBundleURL:(NSURL *)bundleURL | |||
| { | |||
| if (bundleURL && !bundleURL.fileURL) { // isHotLoadingAvailable check | |||
There was a problem hiding this comment.
I assume this comment was a TODO that's now done
✌️ @PeteTheHeat
Base commit: 902611f |
There was a problem hiding this comment.
@PeteTheHeat has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
PeteTheHeat
approved these changes
Sep 14, 2020
| if (self.bridge) { | ||
| [self.bridge enqueueJSCall:@"HMRClient" | ||
| method:@"setup" | ||
| args:@[ @"ios", path, host, RCTNullIfNil(port), @(YES) ] | ||
| args:@[ @"ios", path, host, RCTNullIfNil(port), @(isHotLoadingEnabled) ] |
There was a problem hiding this comment.
Ahh nice catch. I think I must've originally misread this as isHotLoadingAvailable, and assumed that since we've already passed the if condition, this is always true.
|
This pull request was successfully merged by @stigi in 845e9ea. When will my fix make it into a release? | Upcoming Releases |
jpthomson
pushed a commit
to Project-J/react-native
that referenced
this pull request
Oct 19, 2020
) Summary: Disabling Fast Refresh won't be persisted when restarting the app. I believe this regressed with facebook@824e171. In this commit `HMRClient.setup` will always be called with `enabled` being set true. This PR loads the _enabled_ state from the user defaults (as it was done before). ## Changelog [iOS] [Fixed] - Enable Fast Refresh gets persisted across app launches Pull Request resolved: facebook#29880 Test Plan: Without this change Fast Refresh is enabled on every app restart. Tested with this change: - Disabling Fast Refresh - Restarting App -> Fast Refresh still disabled - Enabled Fast Refresh again - Restarting App -> Fast Refresh still enabled again Reviewed By: sammy-SC Differential Revision: D23686435 Pulled By: PeteTheHeat fbshipit-source-id: 42c31b22060d3dc4b1d4cb8f41792b303fc7fce8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Disabling Fast Refresh won't be persisted when restarting the app.
I believe this regressed with 824e171. In this commit
HMRClient.setupwill always be called withenabledbeing set true. This PR loads the enabled state from the user defaults (as it was done before).Changelog
[iOS] [Fixed] - Enable Fast Refresh gets persisted across app launches
Test Plan
Without this change Fast Refresh is enabled on every app restart.
Tested with this change: