Android: Fix switch ripple color #30685
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
analysis-bot
suggested changes
Jan 4, 2021
There was a problem hiding this comment.
Code analysis results:
google-java-formatfound some issues. See https://github.com/google/google-java-format
ReactAndroid/src/main/java/com/facebook/react/views/switchview/ReactSwitch.java
Outdated
Show resolved
Hide resolved
ReactAndroid/src/main/java/com/facebook/react/views/switchview/ReactSwitch.java
Show resolved
Hide resolved
ReactAndroid/src/main/java/com/facebook/react/views/switchview/ReactSwitch.java
Show resolved
Hide resolved
Base commit: 8aea930 |
|
@lunaleaps has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
@lunaleaps merged this pull request in 1b06835. |
|
Thank you @rnike for this PR and tests! I've merged it in! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fix #22370
Use
RippleDrawableto change ripple color.According to the document,
RippleDrawableis added in API 21, so warped the code in theifstatement for version checking.Changelog
[Android] [Fixed] - Fix wrong ripple color on Switch component
Test Plan
node_modules/react-native/ReactAndroid/src/main/java/com/facebook/react/views/switchview/ReactSwitch.javaTest device: Android emulator, Pixel 4, API 30
Screenshot
Before
Ripple is always in default color
before_r.mov
After
Ripple color has changed with thumb color
ripple_fixed.mov
Check different color on each state
ripple_different_color.mov