Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump Android compileSdkVersion and targetSdkVersion to 30 #31078

Closed
wants to merge 4 commits into from
Closed

Bump Android compileSdkVersion and targetSdkVersion to 30 #31078

wants to merge 4 commits into from

Conversation

hramos
Copy link
Contributor

@hramos hramos commented Mar 2, 2021 •
edited
Loading

Summary

Bump Android compileSdkVersion and targetSdkVersion to 30

Changelog

[Android][Changed] Bump Android compileSdkVersion and targetSdkVersion from 29 to 30

Test Plan

Circle CI and Sandcastle

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Mar 2, 2021
@analysis-bot
Copy link

analysis-bot commented Mar 2, 2021 •
edited
Loading

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: caa5abc

@analysis-bot
Copy link

analysis-bot commented Mar 2, 2021 •
edited
Loading

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,902,456 -805
android hermes armeabi-v7a 8,399,646 -773
android hermes x86 9,391,478 -819
android hermes x86_64 9,335,693 -702
android jsc arm64-v8a 10,636,492 -791
android jsc armeabi-v7a 10,116,780 -764
android jsc x86 10,687,000 -823
android jsc x86_64 11,271,489 -693

Base commit: caa5abc

@hramos hramos requested a review from cpojer as a code owner March 2, 2021 18:02
@pull-bot
Copy link

pull-bot commented Mar 2, 2021 •
edited
Loading

Warnings
⚠️ 🔒 package.json - Changes were made to package.json. This will require a manual import by a Facebook employee.
Messages
📖 📋 Missing Summary - Can you add a Summary? To do so, add a "## Summary" section to your PR description. This is a good place to explain the motivation for making this change.

Generated by 🚫 dangerJS against 3e7aa71

@hramos hramos changed the title [test] Verify Android test image support for sdk30 Bump Android compileSdkVersion and targetSdkVersion to 30 Mar 2, 2021
facebook-github-bot
facebook-github-bot reviewed Mar 2, 2021
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hramos has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@hramos merged this pull request in 6ccd0cd.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Mar 3, 2021
@aliaksandr-kazarez
Copy link

@hramos can you briefly explain why build tools was not updated here as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@cpojer cpojer Awaiting requested review from cpojer

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hramos @analysis-bot @pull-bot @facebook-github-bot @aliaksandr-kazarez