Do not include Facebook license on users codegen'd code #31516
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
Base commit: b2dbde3 |
|
Thanks for the PR. Let me run this through our OSS IP team and I'll get back to you. |
hramos
approved these changes
May 14, 2021
|
@hramos has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
facebook-github-bot
added
the
Shared with Meta
cortinico
requested changes
Dec 7, 2021
There was a problem hiding this comment.
Hey @acoates-ms,
Thanks for the PR. I'd like to review it and drive it to landing if you wish.
Can I ask you to:
- Rebase on top of
main - Apply the changes I suggested to all the templates?
| @@ -17,10 +17,10 @@ type FilesOutput = Map<string, string>; | |||
|
|
|||
| const template = ` | |||
| /** | |||
| * Copyright (c) Facebook, Inc. and its affiliates. | |||
| * This code was generated by a tool. | |||
There was a problem hiding this comment.
Suggested change
| * This code was generated by a tool. | |
| * This code was generated by [react-native-codegen](https://www.npmjs.com/package/react-native-codegen). |
Comment on lines
+22
to
+23
| * Changes to this file may cause incorrect behavior and will be lost if | ||
| * the code is regenerated. |
There was a problem hiding this comment.
Suggested change
| * Changes to this file may cause incorrect behavior and will be lost if | |
| * the code is regenerated. | |
| * Do not edit this file as changes may cause incorrect behavior and will be lost | |
| * once the code is regenerated. |
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Jan 6, 2022
Summary: Closes facebook#31516 I've cherry-picked the original PR that had merge conficts + updated all the headers as the one for the TurboModule generators were not handled. Original Commit Message from acoates The codegen generates a Facebook copyright notice at the top of the generated files. While this might make sense on the core files, this codegen will be run on external components too. The notice also refers to a LICENSE file in the root of this project, which might not be there if this is run on another project. I did a quick look at some of the codegen that we ship within windows dev tools, and it looks like we normally just have comments saying the file was codegen'd and so the file shouldn't be manually edited. Open to suggestions on what the comment header should say. Changelog: [General] [Changed] - Do not include Facebook license on users codegen'd code Differential Revision: D33455176 fbshipit-source-id: d64e1a75d23d80a7acae1e15ea7d751d7a316129
|
@acoates-ms I've published this #32840 that is going to close this PR as it has several merge conflicts + The files inside |
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Jan 7, 2022
Summary: Pull Request resolved: facebook#32840 Closes facebook#31516 I've cherry-picked the original PR that had merge conficts + updated all the headers as the one for the TurboModule generators were not handled. Original Commit Message from acoates The codegen generates a Facebook copyright notice at the top of the generated files. While this might make sense on the core files, this codegen will be run on external components too. The notice also refers to a LICENSE file in the root of this project, which might not be there if this is run on another project. I did a quick look at some of the codegen that we ship within windows dev tools, and it looks like we normally just have comments saying the file was codegen'd and so the file shouldn't be manually edited. Open to suggestions on what the comment header should say. Changelog: [General] [Changed] - Do not include Facebook license on users codegen'd code Differential Revision: D33455176 fbshipit-source-id: 5bcc73155d79ee7128726ec040bb6a5f94623baf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The codegen generates a Facebook copyright notice at the top of the generated files. While this might make sense on the core files, this codegen will be run on external components too. The notice also refers to a LICENSE file in the root of this project, which might not be there if this is run on another project. I did a quick look at some of the codegen that we ship within windows dev tools, and it looks like we normally just have comments saying the file was codegen'd and so the file shouldn't be manually edited.
Open to suggestions on what the comment header should say.
Changelog
[General] [Changed] - Do not include Facebook license on users codegen'd code
Test Plan