Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ios] Propose to connect metro server programmatically #31828

Closed
wants to merge 1 commit into from

Conversation

Kudo
Copy link
Contributor

@Kudo Kudo commented Jul 8, 2021

Summary

nowadays, we could only specify metro server by either dev settings or building time ip.txt.
this pr adds a new way to specify metro server programmatically which makes rn launcher or testing more feasible.

Changelog

[Internal] [iOS] [Added] - Propose to connect metro server programmatically

Test Plan

just exposing a public interface for RCTPackagerConnection without much code change.
test to call this interface success locally.

@facebook-github-bot facebook-github-bot added Contributor A React Native contributor. CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Jul 8, 2021
@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: bc1e602

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 9,120,136 +0
android hermes armeabi-v7a 8,646,167 +0
android hermes x86 9,559,472 +0
android hermes x86_64 9,525,646 +0
android jsc arm64-v8a 10,762,843 +0
android jsc armeabi-v7a 9,680,136 +0
android jsc x86 10,797,582 +0
android jsc x86_64 11,405,270 +0

Base commit: bc1e602

@brentvatne brentvatne added the p: Expo Partner: Expo label Jul 9, 2021
@yungsters yungsters added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Sep 10, 2021
@yungsters
Copy link
Contributor

yungsters commented Sep 10, 2021

Not on Android? 😅

Oh, I see #31842 now. 😁

@facebook-github-bot
Copy link
Contributor

@yungsters has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@yungsters merged this pull request in e2b5b65.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Sep 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Contributor A React Native contributor. Merged This PR has been merged. p: Expo Partner: Expo Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants