Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flatten the react-native-codegen included build. #32007

Closed
wants to merge 1 commit into from

Conversation

cortinico
Copy link
Contributor

Summary:
This Diff simplifies the codegen Gradle build.
Previously the build used to have a 2-level nesting of included build.

Turns out that the react-native-codegen/android/build.gradle build
is just providing a task and including an inner build that contains the codegen
Gradle plugin. I've moved such plugin to the outer build.

This will also make sure that the Gradle plugin files are properly index by the
IDE when opening the build (as nested included build are not yet supported).

Changelog:
Internal - Flatten the react-native-codegen Gradle included build

Reviewed By: fkgozali

Differential Revision: D30227784

@facebook-github-bot facebook-github-bot added p: Facebook Partner: Facebook Partner CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported labels Aug 11, 2021
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D30227784

@pull-bot
Copy link

pull-bot commented Aug 11, 2021

Messages
📖

📋 Missing Changelog - Can you add a Changelog? To do so, add a "## Changelog" section to your PR description. A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

CATEGORY may be:
  • General
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)

TYPE may be:

  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.

MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.

📖 📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.
📖 📋 Missing Summary - Can you add a Summary? To do so, add a "## Summary" section to your PR description. This is a good place to explain the motivation for making this change.

Generated by 🚫 dangerJS against e2b391b

@analysis-bot
Copy link

analysis-bot commented Aug 11, 2021

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: ae494e7

@analysis-bot
Copy link

analysis-bot commented Aug 11, 2021

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 9,241,377 +0
android hermes armeabi-v7a 8,753,209 +0
android hermes x86 9,684,376 +0
android hermes x86_64 9,652,583 +0
android jsc arm64-v8a 10,877,528 +0
android jsc armeabi-v7a 9,780,611 +0
android jsc x86 10,915,928 +0
android jsc x86_64 11,525,640 +0

Base commit: ae494e7

Summary:
Pull Request resolved: facebook#32007

This Diff simplifies the codegen Gradle build.
Previously the build used to have a 2-level nesting of included build.

Turns out that the `react-native-codegen/android/build.gradle` build
is just providing a task and including an inner build that contains the codegen
Gradle plugin. I've moved such plugin to the outer build.

This will also make sure that the Gradle plugin files are properly index by the
IDE when opening the build (as nested included build are not yet supported).

Changelog:
Internal - Flatten the `react-native-codegen` Gradle included build

Reviewed By: fkgozali, ShikaSD

Differential Revision: D30227784

fbshipit-source-id: e9a85815dd37bcbee05d67c9065d2ebe05ae06fa
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D30227784

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 1f8c560.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants