Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Resolve NODE_BINARY *after* finding the path to node #32029

Closed
wants to merge 1 commit into from
Closed

fix: Resolve NODE_BINARY *after* finding the path to node #32029

wants to merge 1 commit into from

Conversation

santiagofm
Copy link
Contributor

@santiagofm santiagofm commented Aug 17, 2021 •
edited
Loading

Summary

We want to resolve NODE_BINARY after find-node.sh runs and sets up any node version manager that we need to setup, otherwise NODE_BINARY is always undefined.

Changelog

[Internal] [Fixed] - Resolve NODE_BINARY after finding the right path to node

Test Plan

@facebook-github-bot
Copy link
Contributor

Hi @santiagofm!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 17, 2021
dulmandakh
dulmandakh approved these changes Aug 18, 2021
View reviewed changes
Copy link
Contributor

@dulmandakh dulmandakh left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix works for me 👍 @TheSavior

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@facebook-github-bot facebook-github-bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Aug 18, 2021
@kelset kelset mentioned this pull request Aug 18, 2021
Closed
@yungsters yungsters self-assigned this Aug 18, 2021
@facebook-github-bot
Copy link
Contributor

@yungsters has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@yungsters merged this pull request in d75683a.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Aug 19, 2021
kelset pushed a commit that referenced this pull request Aug 19, 2021
@santiagofm @kelset
fix: Resolve NODE_BINARY *after* finding the path to node (#32029)
fde90a8 
Summary:
We want to resolve `NODE_BINARY` **after** `find-node.sh` runs and sets up any node version manager that we need to setup, otherwise `NODE_BINARY` is always undefined.

## Changelog

[Internal] [Fixed] - Resolve NODE_BINARY after finding the right path to node

Pull Request resolved: #32029

Reviewed By: TheSavior

Differential Revision: D30401213

Pulled By: yungsters

fbshipit-source-id: 386ffeff15b5f371a452488ed078d3adebe0f211
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dulmandakh dulmandakh dulmandakh approved these changes

Assignees

@yungsters yungsters

Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Needs: React Native Team Attention Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@santiagofm @facebook-github-bot @dulmandakh @yungsters @kelset