Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ios): pod install --project-directory=ios fails #32489

Closed
wants to merge 1 commit into from
Closed

fix(ios): pod install --project-directory=ios fails #32489

wants to merge 1 commit into from

Conversation

tido64
Copy link
Collaborator

@tido64 tido64 commented Oct 28, 2021 •
edited
Loading

Summary

Running pod install from outside the ios folder fails because the
path to React-Codegen is wrong:

% pod install --project-directory=ios
[Codegen] Generating ios/build/generated/ios/React-Codegen.podspec.json
Auto-linking React Native module for target `ReactTestApp`: ReactTestApp-DevSupport
Analyzing dependencies
Fetching podspec for `DoubleConversion` from `../node_modules/react-native/third-party-podspecs/DoubleConversion.podspec`
Fetching podspec for `RCT-Folly` from `../node_modules/react-native/third-party-podspecs/RCT-Folly.podspec`
[!] No podspec found for `React-Codegen` in `ios/build/generated/ios`

Changelog

[iOS] [Fixed] - pod install --project-directory=ios fails due to wrong path to React-Codegen

Test Plan

  1. Verify that pod install still works in /packages/rn-tester
  2. Verify that pod install --project-directory=ios also works: 
    git clone https://github.com/microsoft/react-native-test-app.git
cd react-native-test-app
npm run set-react-version main
yarn
cd example
pod install --project-directory=ios

@tido64 tido64 requested review from hramos and sota000 October 28, 2021 07:19
@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Microsoft Partner: Microsoft Partner labels Oct 28, 2021
@tido64 tido64 mentioned this pull request Oct 28, 2021
Closed
34 tasks
@facebook-github-bot facebook-github-bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Oct 28, 2021
@react-native-bot react-native-bot added Bug Platform: iOS iOS applications. labels Oct 28, 2021
@tido64 tido64 mentioned this pull request Oct 28, 2021
Closed
5 tasks
@tido64 tido64 mentioned this pull request Oct 29, 2021
Closed
@tido64 tido64 force-pushed the tido/fix-react-codegen-install branch from bc3eef2 to 6e3a6fd Compare November 1, 2021 09:22
@analysis-bot
Copy link

analysis-bot commented Nov 1, 2021 •
edited
Loading

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: b25d9e4
Branch: main

@analysis-bot
Copy link

analysis-bot commented Nov 1, 2021 •
edited
Loading

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 9,351,093 +0
android hermes armeabi-v7a 8,333,145 +0
android hermes x86 9,983,469 +0
android hermes x86_64 9,768,843 +0
android jsc arm64-v8a 10,665,530 +0
android jsc armeabi-v7a 9,311,071 +0
android jsc x86 10,777,597 +0
android jsc x86_64 11,216,896 +0

Base commit: b25d9e4
Branch: main

@tido64
fix(ios): pod install --project-directory=ios fails
3dd64d3 
Running `pod install` from outside the the `ios` folder fails because
the path to `React-Codegen` is wrong:

```
% pod install --project-directory=ios
[Codegen] Generating ios/build/generated/ios/React-Codegen.podspec.json
Auto-linking React Native module for target `ReactTestApp`: ReactTestApp-DevSupport
Analyzing dependencies
Fetching podspec for `DoubleConversion` from `../node_modules/react-native/third-party-podspecs/DoubleConversion.podspec`
Fetching podspec for `RCT-Folly` from `../node_modules/react-native/third-party-podspecs/RCT-Folly.podspec`
[!] No podspec found for `React-Codegen` in `ios/build/generated/ios`
```
@tido64 tido64 force-pushed the tido/fix-react-codegen-install branch from 6e3a6fd to 3dd64d3 Compare November 3, 2021 15:15
@facebook-github-bot
Copy link
Contributor

@sota000 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@sota000
Copy link
Contributor

sota000 commented Nov 4, 2021

Thanks for fixing this, @tido64! Will merge this shortly.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Nov 4, 2021
@facebook-github-bot
Copy link
Contributor

@sota000 merged this pull request in ebb26cf.

@tido64 tido64 deleted the tido/fix-react-codegen-install branch November 4, 2021 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kelset kelset kelset approved these changes

@hramos hramos Awaiting requested review from hramos

@sota000 sota000 Awaiting requested review from sota000

Assignees
No one assigned
Labels
Bug CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Needs: React Native Team Attention p: Microsoft Partner: Microsoft Partner Platform: iOS iOS applications. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tido64 @analysis-bot @facebook-github-bot @sota000 @kelset @react-native-bot