Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RetryableMountingException from Switch causing stuck ui operation #32601

Conversation

jonathanmos
Copy link
Contributor

@jonathanmos jonathanmos commented Nov 16, 2021

Summary:
Changelog:
[Android][Fixed] - Change useLayoutEffect to useEffect to fix #32594 - stuck operation in mViewCommandOperations list in Android Release on initial layout of a screen with Switch component.

Summary

This PR fixes the RetryableMountingException that was generated by Switch on Android Release during initial layout - #32594

Changelog

Changed useLayoutEffect to useEffect

Test Plan

To reproduce, put a log in UIViewOperationQueue in dispatchViewUpdates you can see that the RetryableMountingException is no longer thrown. As a result, mViewCommandOperations no longer has a stuck operation on initial layout.

Summary:
Changelog:
Change useLayoutEffect to useEffect to fix facebook#32594 (stuck operation in viewcommands list in Android Release)
@facebook-github-bot
Copy link
Contributor

Hi @jonathanmos!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@pull-bot
Copy link

Warnings
⚠️

❔ Base Branch - The base branch for this PR is something other than main. Are you sure you want to merge these changes into a stable release? If you are interested in backporting updates to an older release, the suggested approach is to land those changes on main first and then cherry-pick the commits into the branch for that release. The Releases Guide has more information.

Messages
📖

📋 Verify Changelog Format - A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

CATEGORY may be:
  • General
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)

TYPE may be:

  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.

MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.

Generated by 🚫 dangerJS against adf5e90

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 1d6af14

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,942,992 +465,919
android hermes armeabi-v7a 8,477,886 +701,290
android hermes x86 9,362,005 +416,047
android hermes x86_64 9,329,239 +439,175
android jsc arm64-v8a 10,626,433 +834,543
android jsc armeabi-v7a 9,548,857 +796,232
android jsc x86 10,639,743 +899,027
android jsc x86_64 11,250,653 +909,084

Base commit: 1d6af14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants