-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Removes interface only check from third party components GenerateThirdPartyFabricComponentsProvider #32779
Conversation
Hi @Ubax! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Base commit: dc5cae5 |
Base commit: dc5cae5 |
Ohh, I need the CLA to be added. I'll import it after that's added. cc: @Ubax |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to get this back on your plate about the CLA.
@sota000 I filled CLA |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
@ShikaSD has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
hey, do you mind also updating test fixtures in the |
Yeah sure |
@ShikaSD done |
@ShikaSD has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Awesome, I hit this issue too when trying the new architecture with an interfaceOnly component. I can confirm this fixes the issue. |
This pull request was successfully merged by @Ubax in 3e69022. When will my fix make it into a release? | Upcoming Releases |
Summary
Currently the codegen does not include component with field
interfaceOnly
set totrue
in theThirdPartyFabricComponentsProvider
.These components need to be added to this file, so that non-core components can be used in fabric.
Changelog
[General [Fixed] - Fixes GenerateThirdPartyFabricComponentsProvider
Test Plan
Run codegen with component outside of core on iOS.
Check if components with and without
interfaceOnly
are added toRCTThirdPartyFabricComponentsProvider