Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gradle-download-task to 5.0.1 #32995

Closed
wants to merge 1 commit into from
Closed

Update gradle-download-task to 5.0.1 #32995

wants to merge 1 commit into from

Conversation

michel-kraemer
Copy link
Contributor

@michel-kraemer michel-kraemer commented Jan 29, 2022

Summary

This enables concurrent task exection and parallel downloads

See also michel-kraemer/gradle-download-task#138

Changelog

[General] [Changed] - Update gradle-download-task to 5.0.1 to support concurrent downloads

Test Plan

Build runs successfully.

@facebook-github-bot
Copy link
Contributor

Hi @michel-kraemer!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@analysis-bot
Copy link

analysis-bot commented Jan 29, 2022

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 0ab0c5a
Branch: main

@analysis-bot
Copy link

analysis-bot commented Jan 29, 2022

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,300,241 -8
android hermes armeabi-v7a 7,639,075 +1
android hermes x86 8,776,062 -8
android hermes x86_64 8,712,723 +2
android jsc arm64-v8a 9,784,556 -20
android jsc armeabi-v7a 8,770,727 -26
android jsc x86 9,751,550 -17
android jsc x86_64 10,347,472 -22

Base commit: 0ab0c5a
Branch: main

This enables concurrent task exection and parallel downloads

See also michel-kraemer/gradle-download-task#138
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 29, 2022
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@michel-kraemer michel-kraemer changed the title Update gradle-download-task to 5.0.0 Update gradle-download-task to 5.0.1 Jan 29, 2022
@facebook-github-bot facebook-github-bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Jan 29, 2022
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot
Copy link
Contributor

@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@cortinico
Copy link
Contributor

Thanks for doing this @michel-kraemer
I had it on my backlog but haven't managed to find time to look into it as our setup is rather complex. Thanks for doing it. 🙏

I believe the Internal CI Job will fail as this requires an update of the offline mirror. You can disregard it and we should be good to merge it 👍

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @michel-kraemer in a86cae7.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Feb 2, 2022
@michel-kraemer michel-kraemer deleted the gradle-download-task-5 branch February 3, 2022 04:39
shwanton pushed a commit to shwanton/react-native-macos that referenced this pull request Feb 13, 2023
Summary:
This enables concurrent task exection and parallel downloads

See also michel-kraemer/gradle-download-task#138

## Changelog

[General] [Changed] - Update gradle-download-task to 5.0.1 to support concurrent downloads

Pull Request resolved: facebook#32995

Test Plan: Build runs successfully.

Reviewed By: ShikaSD

Differential Revision: D33892817

Pulled By: cortinico

fbshipit-source-id: 515443573e17a5c2b16a1cf3cea4bf3c5c2d96a7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants