Set a resolution strategy for com.facebook.react:react-native when on New Architecture. #33134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… New Architecture. Summary: When a user is enabling New Architecture, we should make sure they don't accidentally mix imports of React Native from source vs prebuilts. With this resolution strategy, we'll make sure all the import of `com.facebook.react:react-native:+` will be resolved to the correct dependency. Changelog: [Android] [Fixed] - Set a resolution strategy for com.facebook.react:react-native when on New Architecture Differential Revision: D34303267 fbshipit-source-id: d59de872ec7700a5d060fe28dd5c5d1dbb8f453e
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D34303267 |
Base commit: 062c1f7 |
Base commit: 062c1f7 |
|
This pull request was successfully merged by @cortinico in e695bc0. When will my fix make it into a release? | Upcoming Releases |
ShikaSD
pushed a commit
that referenced
this pull request
Feb 24, 2022
… New Architecture. (#33134) Summary: Pull Request resolved: #33134 When a user is enabling New Architecture, we should make sure they don't accidentally mix imports of React Native from source vs prebuilts. With this resolution strategy, we'll make sure all the import of `com.facebook.react:react-native:+` will be resolved to the correct dependency. Changelog: [Android] [Fixed] - Set a resolution strategy for com.facebook.react:react-native when on New Architecture Reviewed By: ShikaSD Differential Revision: D34303267 fbshipit-source-id: 492fec59175c5887571e1b09ca8e233584b45dd1
ShikaSD
pushed a commit
that referenced
this pull request
Feb 24, 2022
… New Architecture. (#33134) Summary: Pull Request resolved: #33134 When a user is enabling New Architecture, we should make sure they don't accidentally mix imports of React Native from source vs prebuilts. With this resolution strategy, we'll make sure all the import of `com.facebook.react:react-native:+` will be resolved to the correct dependency. Changelog: [Android] [Fixed] - Set a resolution strategy for com.facebook.react:react-native when on New Architecture Reviewed By: ShikaSD Differential Revision: D34303267 fbshipit-source-id: 492fec59175c5887571e1b09ca8e233584b45dd1
This was referenced Apr 21, 2022
This was referenced Nov 14, 2022
Saadnajmi
pushed a commit
to Saadnajmi/react-native-macos
that referenced
this pull request
Jan 15, 2023
… New Architecture. (facebook#33134) Summary: Pull Request resolved: facebook#33134 When a user is enabling New Architecture, we should make sure they don't accidentally mix imports of React Native from source vs prebuilts. With this resolution strategy, we'll make sure all the import of `com.facebook.react:react-native:+` will be resolved to the correct dependency. Changelog: [Android] [Fixed] - Set a resolution strategy for com.facebook.react:react-native when on New Architecture Reviewed By: ShikaSD Differential Revision: D34303267 fbshipit-source-id: 492fec59175c5887571e1b09ca8e233584b45dd1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
When a user is enabling New Architecture, we should make sure they don't accidentally mix
imports of React Native from source vs prebuilts.
With this resolution strategy, we'll make sure all the import of
com.facebook.react:react-native:+will be resolved to the correct dependency.
Changelog:
[Android] [Fixed] - Set a resolution strategy for com.facebook.react:react-native when on New Architecture
Differential Revision: D34303267