Export REACT_NATIVE_PATH and fix find-node-for-xcode.sh fallback behavior #33674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D35779165 |
Base commit: 29c5461 |
Base commit: 29c5461 |
…vior (facebook#33674) Summary: Pull Request resolved: facebook#33674 ## Issue In D35317070 (facebook@0480f56) we introduced a way to configuring the Xcode environment via he `.xcode.env`, falling back to the old `find-node-for-xcode.sh` behavior in case of a misconfiguration. Unfortunately, there were an issue with the new architecture for which the pods were not able to locate the `find-node-for-xcode.sh`, crashing while building the new architecture. ## Solution This Diff solves the issue in two steps: 1. it exposes to the project the REACT_NATIVE_PATH like Android does here: D35451821 (facebook@f8d7e0a) 2. it leverages this new variables to reach the script ## Changelog [iOS][Changed] - Fixed the fallback behavior when the `.xcode.env` file is missing, actually using the old `find-node-for-xcode.sh` script Differential Revision: D35779165 fbshipit-source-id: 8bb96dcc68c9634ef4d00fdbed612f377af2ee41
|
This pull request was exported from Phabricator. Differential Revision: D35779165 |
cipolleschi
force-pushed
the
export-D35779165
branch
from
75511c9
to
0e45f28
Compare
|
This pull request was successfully merged by @cipolleschi in 705c6f5. When will my fix make it into a release? | Upcoming Releases |
Saadnajmi
pushed a commit
to Saadnajmi/react-native-macos
that referenced
this pull request
Jan 15, 2023
…vior (facebook#33674) Summary: Pull Request resolved: facebook#33674 In D35317070 (facebook@0480f56) we introduced a way to configuring the Xcode environment via he `.xcode.env`, falling back to the old `find-node-for-xcode.sh` behavior in case of a misconfiguration. Unfortunately, there were an issue with the new architecture for which the pods were not able to locate the `find-node-for-xcode.sh`, crashing while building the new architecture. This Diff solves the issue in two steps: 1. it exposes to the project the REACT_NATIVE_PATH like Android does here: D35451821 (facebook@f8d7e0a) 2. it leverages this new variables to reach the script [iOS][Changed] - Fixed the fallback behavior when the `.xcode.env` file is missing, actually using the old `find-node-for-xcode.sh` script Reviewed By: dmitryrykun Differential Revision: D35779165 fbshipit-source-id: 393ef9a0b98d32d9cf226f7d109fdefd772e5120
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
In D35317070 (0480f56) we introduced a way to configuring the Xcode environment via he
.xcode.env, falling back to the oldfind-node-for-xcode.shbehavior in case of a misconfiguration.Unfortunately, there were an issue with the new architecture for which the pods were not able to locate the
find-node-for-xcode.sh, crashing while building the new architecture.Solution
This Diff solves the issue in two steps:
NOTE
This pr depends on this and this
Changelog
[iOS][Changed] - Fixed the fallback behavior when the
.xcode.envfile is missing, actually using the oldfind-node-for-xcode.shscriptDifferential Revision: D35779165