[android] add back hermes inspector support #33778
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
Base commit: ed46ea2 |
|
@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Base commit: 9328115 |
|
This pull request was successfully merged by @Kudo in 6b6adcc. When will my fix make it into a release? | Upcoming Releases |
fortmarek
pushed a commit
that referenced
this pull request
May 11, 2022
Summary: the `WITH_INSPECTOR` build flag is missing from cmake migration. original we had it in [Application.mk](https://github.com/facebook/react-native/blob/ed46ea2058b909a2dd401347d68956324961ec2c/ReactAndroid/src/main/jni/Application.mk#L29) this pr adds back the build flag and make hermes inspector (or debugging hermes in flipper) work again. ## Changelog [Android] [Fixed] - add back hermes inspector support Pull Request resolved: #33778 Test Plan: test on rn-tester hermes variant Reviewed By: cipolleschi Differential Revision: D36204525 Pulled By: cortinico fbshipit-source-id: 417874a7d0e05b5ee886f3160d526ff9c2df44ee
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
the
WITH_INSPECTORbuild flag is missing from cmake migration. original we had it in Application.mkthis pr adds back the build flag and make hermes inspector (or debugging hermes in flipper) work again.
Changelog
[Android] [Fixed] - add back hermes inspector support
Test Plan
test on rn-tester hermes variant