Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Android Gradle Plugin to 7.2.0 #33817

Closed
wants to merge 1 commit into from

Conversation

dulmandakh
Copy link
Contributor

@dulmandakh dulmandakh commented May 12, 2022

Summary

Bump Android Gradle Plugin to 7.2.0 (May 2022), which supported by latest Android Studio (Chipmunk). See https://developer.android.com/studio/releases/gradle-plugin#7-2-0

Changelog

[Android] [Changed] - Bump Android Gradle Plugin to 7.2.0

Test Plan

Everything builds and runs as expected

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Contributor A React Native contributor. labels May 12, 2022
@analysis-bot
Copy link

analysis-bot commented May 12, 2022

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,777,989 -11,993
android hermes armeabi-v7a 7,181,612 -11,904
android hermes x86 8,087,907 -11,944
android hermes x86_64 8,067,006 -11,952
android jsc arm64-v8a 9,651,150 -11,501
android jsc armeabi-v7a 8,423,530 -11,428
android jsc x86 9,601,660 -11,463
android jsc x86_64 10,197,934 -11,487

Base commit: a897314
Branch: main

@dulmandakh dulmandakh changed the title AGP 7.2.0 Bump Android Gradle Plugin to 7.2.0 May 12, 2022
@dulmandakh dulmandakh marked this pull request as ready for review May 12, 2022 13:39
@react-native-bot react-native-bot added the Platform: Android Android applications. label May 12, 2022
@facebook-github-bot facebook-github-bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label May 12, 2022
@cortinico
Copy link
Contributor

Thanks for sending this over @dulmandakh. If possible I'd like to:

  1. Split this in 4 separate PRs (Gradle, AGP 7.1, AGP 7.2, Download task).
  2. Keep the Jetifier outside of this as this would require a related change also in the CLI

@dulmandakh
Copy link
Contributor Author

@cortinico first PR is ready, only APG 7.2.0

@facebook-github-bot
Copy link
Contributor

@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @dulmandakh in c274456.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label May 16, 2022
leotm added a commit to leotm/react-native-template-new-architecture that referenced this pull request Jun 26, 2022
- Fix: #719
- Downgrade AGP from 7.4.0-alpha03 ❌
- AGP 7.2.0 ✅  facebook/react-native#33817
- AGP 7.4.0-beta03 ❌
- AGP 7.2.1 ✅

Flipper

FATAL EXCEPTION: create_react_context

java.lang.RuntimeException: Unable to load script. Make sure you're either running Metro (run 'npx react-native start') or that your bundle 'index.android.bundle' is packaged correctly for release.

FATAL EXCEPTION: create_react_context
Process: com.leotm.myapp, PID: 13832
java.lang.RuntimeException: Unable to load script. Make sure you're either running Metro (run 'npx react-native start') or that your bundle 'index.android.bundle' is packaged correctly for release.
	at com.facebook.react.bridge.CatalystInstanceImpl.jniLoadScriptFromAssets(Native Method)
	at com.facebook.react.bridge.CatalystInstanceImpl.loadScriptFromAssets(CatalystInstanceImpl.java:248)
	at com.facebook.react.bridge.JSBundleLoader$1.loadScript(JSBundleLoader.java:29)
	at com.facebook.react.bridge.CatalystInstanceImpl.runJSBundle(CatalystInstanceImpl.java:277)
	at com.facebook.react.ReactInstanceManager.createReactContext(ReactInstanceManager.java:1404)
	at com.facebook.react.ReactInstanceManager.access$1200(ReactInstanceManager.java:136)
	at com.facebook.react.ReactInstanceManager$5.run(ReactInstanceManager.java:1108)
	at java.lang.Thread.run(Thread.java:920)
facebook-github-bot pushed a commit that referenced this pull request Jul 12, 2022
Summary:
- Fix: #34103
- Follow-up: #33817

## Changelog

<!-- Help reviewers and the release process by writing your own changelog entry. For an example, see:
https://github.com/facebook/react-native/wiki/Changelog
-->

[Android] [Changed] - Bump Android Gradle Plugin to 7.2.1

Pull Request resolved: #34166

Test Plan: Everything builds and runs as expected

Reviewed By: javache

Differential Revision: D37747754

Pulled By: cortinico

fbshipit-source-id: b51f26d773ddfbdaf4490f89f3b207a41b225a82
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Contributor A React Native contributor. Merged This PR has been merged. Platform: Android Android applications. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants