Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pod install --project-directory=ios failing when Hermes is enabled #33819

Merged
merged 1 commit into from
May 17, 2022
Merged

Fix pod install --project-directory=ios failing when Hermes is enabled #33819

merged 1 commit into from
May 17, 2022

Conversation

tido64
Copy link
Collaborator

@tido64 tido64 commented May 12, 2022 •
edited
Loading

Summary

pod install --project-directory=ios fails when Hermes is enabled:

% pod install --project-directory=ios
[Codegen] Generating ios/build/generated/ios/React-Codegen.podspec.json
[Hermes] Extracting Hermes tarball (5244f8)

[DEBUG] pwd: /~/example
[DEBUG] cp: cp ../node_modules/react-native/sdks/hermes-engine.podspec ../node_modules/react-native/sdks/hermes/hermes-engine.podspec

warn Multiple Podfiles were found: ios/Podfile,macos/Podfile. Choosing ios/Podfile automatically. If you would like to select a different one, you can configure it via "project.ios.sourceDir". You can learn more about it here: https://github.com/react-native-community/cli/blob/master/docs/configuration.md
Auto-linking React Native module for target `ReactTestApp`: ReactTestApp-DevSupport
Analyzing dependencies
Fetching podspec for `DoubleConversion` from `../node_modules/react-native/third-party-podspecs/DoubleConversion.podspec`
[Codegen] Found FBReactNativeSpec
Fetching podspec for `RCT-Folly` from `../node_modules/react-native/third-party-podspecs/RCT-Folly.podspec`
Fetching podspec for `boost` from `../node_modules/react-native/third-party-podspecs/boost.podspec`
Fetching podspec for `glog` from `../node_modules/react-native/third-party-podspecs/glog.podspec`
[!] No podspec found for `hermes-engine` in `../node_modules/react-native/sdks/hermes/hermes-engine.podspec`

Changelog

[iOS] [Fixed] - pod install --project-directory=ios fails when Hermes is enabled

Test Plan

Running pod install --project-directory=ios is enough to trigger this issue.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 12, 2022
tido64
tido64 commented May 12, 2022
View reviewed changes
scripts/react_native_pods.rb

# TODO: Integrate this temporary hermes-engine.podspec into the actual one located in facebook/hermes
system("cp #{sdks_dir}/hermes-engine.podspec #{hermes_dir}/hermes-engine.podspec")
FileUtils.cp(sdks_dir.join("hermes-engine.podspec"), hermes_dir.join("hermes-engine.podspec"))
Copy link
Collaborator Author

@tido64 tido64 May 12, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will make made a separate PR targeting main since this section has changed a bit since the cut: #33820

@facebook-github-bot facebook-github-bot added p: Microsoft Partner: Microsoft Partner Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels May 12, 2022
@react-native-bot react-native-bot added Bug Platform: iOS iOS applications. labels May 12, 2022
@tido64 tido64 mentioned this pull request May 12, 2022
Closed
@hramos hramos self-assigned this May 14, 2022
@hramos hramos merged commit f880373 into 0.69-stable May 17, 2022
@hramos
Copy link
Contributor

hramos commented May 17, 2022

Merging fix onto 0.69-stable. Do we need to do the same on main, for the new hermes-utils script?

@tido64 tido64 deleted the tido/fix-pod-install-0.69 branch May 18, 2022 06:41
@tido64
Copy link
Collaborator Author

tido64 commented May 18, 2022

Merging fix onto 0.69-stable. Do we need to do the same on main, for the new hermes-utils script?

I haven't checked what the new script does, but you should be able to repro this by running pod install --project-directory=packages/rn-tester from repo root.

fortmarek added a commit that referenced this pull request May 20, 2022
@fortmarek
Revert "Merge pull request #33819 from facebook/tido/fix-pod-install-…
06ec3aa 
…0.69"

This reverts commit f880373, reversing
changes made to 3310ccd.
@tido64 tido64 mentioned this pull request May 31, 2022
Closed
34 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hramos hramos Awaiting requested review from hramos

@cortinico cortinico Awaiting requested review from cortinico

@fortmarek fortmarek Awaiting requested review from fortmarek

@kelset kelset Awaiting requested review from kelset

Assignees

@hramos hramos

Labels
Bug CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Microsoft Partner: Microsoft Partner Platform: iOS iOS applications. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tido64 @hramos @facebook-github-bot @react-native-bot