Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hermes: Build Hermes apple runtime artifacts #33876

Closed
wants to merge 3 commits into from

Conversation

hramos
Copy link
Contributor

@hramos hramos commented May 20, 2022

Summary:
WIP. Published so we can export and test on CI.

These two jobs can likely be merged onto the existing build_hermesc_macos job.

Changelog: [Internal]

Differential Revision: D36538847

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner fb-exported labels May 20, 2022
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D36538847

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D36538847

hramos added a commit to hramos/react-native that referenced this pull request May 20, 2022
Summary:
Pull Request resolved: facebook#33876

WIP. Published so we can export and test on CI.

These two jobs can likely be merged onto the existing build_hermesc_macos job.

Changelog: [Internal]

Differential Revision: D36538847

fbshipit-source-id: b0412997316d75dd40f7787a5355c85459a4a31d
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D36538847

hramos added a commit to hramos/react-native that referenced this pull request May 20, 2022
Summary:
Pull Request resolved: facebook#33876

WIP. Published so we can export and test on CI.

These two jobs can likely be merged onto the existing build_hermesc_macos job.

Changelog: [Internal]

Differential Revision: D36538847

fbshipit-source-id: c3a97b96eaebab255a84de69107ac04e3963f371
cipolleschi pushed a commit to cipolleschi/react-native that referenced this pull request May 20, 2022
Summary:
Pull Request resolved: facebook#33876

WIP. Published so we can export and test on CI.

These two jobs can likely be merged onto the existing build_hermesc_macos job.

Changelog: [Internal]

Differential Revision: D36538847

fbshipit-source-id: 4b6ffdf0ebd156c496d964f0a2ec030d0760940d
cipolleschi pushed a commit to cipolleschi/react-native that referenced this pull request May 20, 2022
Summary:
Pull Request resolved: facebook#33876

WIP. Published so we can export and test on CI.

These two jobs can likely be merged onto the existing build_hermesc_macos job.

Changelog: [Internal]

Differential Revision: D36538847

fbshipit-source-id: d2d1f43526a68b7e52501c80565826885d391d17
cipolleschi pushed a commit to cipolleschi/react-native that referenced this pull request May 20, 2022
Summary:
Pull Request resolved: facebook#33876

WIP. Published so we can export and test on CI.

These two jobs can likely be merged onto the existing build_hermesc_macos job.

Changelog: [Internal]

Differential Revision: D36538847

fbshipit-source-id: 37654f8537b454409fd8bc6b25f7074d5f9e95fd
cipolleschi pushed a commit to cipolleschi/react-native that referenced this pull request May 20, 2022
Summary:
Pull Request resolved: facebook#33876

WIP. Published so we can export and test on CI.

These two jobs can likely be merged onto the existing build_hermesc_macos job.

Changelog: [Internal]

Differential Revision: D36538847

fbshipit-source-id: ef10bf1b0f8d03af9c8c9b76a8c53a6e294ccb11
cipolleschi pushed a commit to cipolleschi/react-native that referenced this pull request May 20, 2022
Summary:
Pull Request resolved: facebook#33876

WIP. Published so we can export and test on CI.

These two jobs can likely be merged onto the existing build_hermesc_macos job.

Changelog: [Internal]

Differential Revision: D36538847

fbshipit-source-id: 2cd2c6b16be7157de0b22d1bb02fa1381e63a917
Differential Revision: D36532561

fbshipit-source-id: dea7bdfa3022f68bd52155d603da82bc92c93c0e
Differential Revision: D36533683

fbshipit-source-id: f01bae367f8aed078525f297873cb4d68760ff72
Summary:
Pull Request resolved: facebook#33876

WIP. Published so we can export and test on CI.

These two jobs can likely be merged onto the existing build_hermesc_macos job.

Changelog: [Internal]

Differential Revision: D36538847

fbshipit-source-id: 15dad8def3e59e04a61cdf1ceb4fb8a0b4a02347
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D36538847

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 291f26c
Branch: main

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @hramos in 8e80dc8.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label May 23, 2022
cortinico pushed a commit that referenced this pull request May 30, 2022
Summary:
Pull Request resolved: #33876

WIP. Published so we can export and test on CI.

These two jobs can likely be merged onto the existing build_hermesc_macos job.

Changelog: [Internal]

Reviewed By: cipolleschi

Differential Revision: D36538847

fbshipit-source-id: e52c39ccfe652e70c54fd4892513c0060c3f021d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants