Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Draft, for CI] Initial experimenting with new Repo Structure #33912

Closed
wants to merge 3 commits into from

Conversation

empyrical
Copy link
Contributor

Summary

The purpose of this draft pull request is to experiment with restructuring the React Native repository. It is not intended to be merged, it is to run CI. I am making a script that restructures/patches the repo as per my comment in react-native-community/discussions-and-proposals#480, because maintaining a pull request by hand to keep up with the pace of this repo's change would be infeasible.

Changelog

[CATEGORY] [TYPE] - Message

Test Plan

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Contributor A React Native contributor. labels May 26, 2022
@pull-bot
Copy link

pull-bot commented May 26, 2022

Fails
🚫

📋 Verify Changelog Format - A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

CATEGORY may be:
  • General
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)

TYPE may be:

  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.

MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.

Warnings
⚠️ 🔒 package.json - Changes were made to package.json. This will require a manual import by a Facebook employee.

Generated by 🚫 dangerJS against 62c39a3

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 0ef73f2
Branch: main

@github-actions
Copy link

github-actions bot commented Dec 2, 2022

This PR is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale There has been a lack of activity on this issue and it may be closed soon. label Dec 2, 2022
@kelset
Copy link
Contributor

kelset commented Dec 2, 2022

@cortinico @hoxyq this was one of the earlier attempts at moving things around to reshape the repo into what the RFC monorepo was proposing.

I reckon, now that you are doing the work and it's landing on main, that potentially this PR might be closed?
@empyrical what do you think?

@hoxyq
Copy link
Contributor

hoxyq commented Dec 2, 2022

@cortinico @hoxyq this was one of the earlier attempts at moving things around to reshape the repo into what the RFC monorepo was proposing.

I reckon, now that you are doing the work and it's landing on main, that potentially this PR might be closed? @empyrical what do you think?

Yeah, might use it as a reference, but I think we can close this one

Right now we are in a process of discussing what exactly we are moving to the package /packages/react-native, will update a bit later on that

@cortinico
Copy link
Contributor

I reckon, now that you are doing the work and it's landing on main, that potentially this PR might be closed? @empyrical what do you think?

Yup closing this. Thanks for your effort @empyrical, it was fundamental to kickoff this work

@cortinico cortinico closed this Dec 2, 2022
@empyrical
Copy link
Contributor Author

Thank you! Sorry I wasn't able to follow up on this in a timely manner but some life stuff came up and I wasn't able to focus on open source for a while. If there's still a way that I could help out with this effort I'd love to however.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Contributor A React Native contributor. Stale There has been a lack of activity on this issue and it may be closed soon.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants