Refactor: Minor performance improvement of BackHandler.removeEventListener

[vitalii-tb]

Summary

I've noticed that BackHandler.removeEventListener() performs two same indexOf() calls on an array that is not changing. By removing extra indexOf we can slightly improve time complexity of BackHandler.removeEventListener() from O(2n) to O(n)

Changelog

[Android] [Fixed] - Remove extra indexOf call in BackHandler.removeEventListener

Test Plan

1. Add the following code to any function component

  BackHandler.addEventListener('hardwareBackPress', () => true).remove();

2. Press on hardware back button

Expected result: Application closes

[facebook-github-bot]

Hi @tabakharniuk!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	7,825,802	-5
android	hermes	armeabi-v7a	7,216,786	-5
android	hermes	x86	8,137,903	-2
android	hermes	x86_64	8,116,246	+2
android	jsc	arm64-v8a	9,703,632	+9
android	jsc	armeabi-v7a	8,458,139	+1
android	jsc	x86	9,654,101	+2
android	jsc	x86_64	10,252,087	+8

Base commit: 8441c4a
Branch: main

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
ios	-	universal	n/a	--

Base commit: 8441c4a
Branch: main

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

[facebook-github-bot]

@javache has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[react-native-bot]

This pull request was successfully merged by @tabakharniuk in 14c207d.

^{When will my fix make it into a release? | Upcoming Releases}