-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/role to accessibility role mapping #34538
Feat/role to accessibility role mapping #34538
Conversation
Hi @madhav23bansal! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
Hi @necolas, I have added mapping as given in the examples, but I was a bit confused about the mapping of roles that exist on the web but do not exist on react native. |
Base commit: 5c109b3 |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Base commit: 5c109b3 |
I think the flow type should allow all the values supported on web. We just don't forward unsupported values to the inner component |
Hi @necolas, I have added all the roles supported on the web, just have not mapped them to View. |
@jacdebug has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Thank you for all the follow-ups @madhav23bansal |
@jacdebug has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
@jacdebug has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
This pull request was successfully merged by @madhav23bansal in a50e6fb. When will my fix make it into a release? | Upcoming Releases |
Summary
This adds role alias for accessibilityRole, it unifies role and accessibilityRole as requested on #34424
Changelog
[General][Added] - Added role alias for accessibilityRole.
Test Plan