-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Alert
not showing in an app using UIScene
#34562
Conversation
Base commit: 7aa203b |
Sorry why does removing the |
Sorry I wasn't clear in the description. The issue is the fact that we create a new window to present an alert from. From what I've gathered, this works only if we're using the old way of writing iOS apps because windows automatically get attached. If we're using |
Summary In an app using `UIScene`, `Alert` no longer pops up because the window that gets created are not attached to a scene. Changelog [iOS] [Fixed] - Fix `Alert` not showing in an app using `UIScene` Test Plan Use the test plan in #29295. This should not regress that fix.
aed3e2d
to
d52f7ff
Compare
Base commit: 7aa203b |
@lunaleaps has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
This pull request was successfully merged by @tido64 in 153aedc. When will my fix make it into a release? | Upcoming Releases |
Summary: Changelog: [Internal] - Revert #34562 re: [iOS] [Fixed] - Fix Alert not showing in an app using UIScene Reviewed By: alsun2001 Differential Revision: D39591113 fbshipit-source-id: ba707c11b3fb97eb3a6fee32e57b92403aa8b3d8
@tido64 We had to revert this as this was regressing behavior of an internal use-case where an Alert was shown inside a Modal. With these changes, the Alert doesn't appear. From a Meta engineer, they debugged it and found that Repro example
|
@lunaleaps Thanks for letting me know. I'll find a different fix for this. |
Summary: In an app using `UIScene`, `Alert` no longer pops up because the window that gets created are not attached to a scene. ## Changelog [iOS] [Fixed] - Fix `Alert` not showing in an app using `UIScene` Pull Request resolved: facebook#34562 Test Plan: Use the test plan in facebook#29295. This should not regress that fix. Reviewed By: cipolleschi Differential Revision: D39276976 Pulled By: lunaleaps fbshipit-source-id: e48e985ed4abec77d6f01a6c17292d664ed88f13
Summary: Changelog: [Internal] - Revert facebook#34562 re: [iOS] [Fixed] - Fix Alert not showing in an app using UIScene Reviewed By: alsun2001 Differential Revision: D39591113 fbshipit-source-id: ba707c11b3fb97eb3a6fee32e57b92403aa8b3d8
Summary
In an app using
UIScene
,Alert
no longer pops up because the windowthat gets created are not attached to a scene.
Changelog
[iOS] [Fixed] - Fix
Alert
not showing in an app usingUIScene
Test Plan
Use the test plan in #29295. This should not regress that fix.