Remove usage of UIApplication.sharedApplication #34787
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Brings in line with rest of code base and avoids running into this error ``` ‘sharedApplication’ is unavailable: not available on iOS (App Extension) — Use view controller based solutions where appropriate instead. ``` when `Requires Only App-Extension-Safe-API` is set to Yes.
facebook-github-bot
added
CLA Signed
cipolleschi
approved these changes
Sep 26, 2022
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Base commit: cc13b02 |
Base commit: cc13b02 |
|
This pull request was successfully merged by @evoactivity in 5e79fa8. When will my fix make it into a release? | Upcoming Releases |
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
Summary: Brings in line with rest of code base and avoids running into this error ``` ‘sharedApplication’ is unavailable: not available on iOS (App Extension) — Use view controller based solutions where appropriate instead. ``` when `Requires Only App-Extension-Safe-API` is set to Yes. ## Changelog [iOS] [Fixed] - Update usage of UIApplication.sharedApplication in RCTKeyCommands Pull Request resolved: facebook#34787 Test Plan: Setting `Requires Only App-Extension-Safe-API` to Yes before this change means the app will not compile, after the change it does. Reviewed By: dmytrorykun Differential Revision: D39812410 Pulled By: cipolleschi fbshipit-source-id: 78d185ba20301b10609e4a387f000f0cfda55663
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Brings in line with rest of code base and avoids running into this error
when
Requires Only App-Extension-Safe-APIis set to Yes.Changelog
[iOS] [Fixed] - Update usage of UIApplication.sharedApplication in RCTKeyCommands
Test Plan
Setting
Requires Only App-Extension-Safe-APIto Yes before this change means the app will not compile, after the change it does.