Restore Filtering platform in codegen #35028
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D40516395 |
react-native-bot
added
the
Type: Enhancement
Base commit: 76c7cca |
Base commit: 76c7cca |
Summary: This diff bumps the codegen to v0.71.1, preparing it for the branch cut. ## Changelog [General][Changed] - Bump codegen version Differential Revision: https://internalfb.com/D40852498 fbshipit-source-id: d3682aaec58be7bbec024a88a4b9d86300f4db1d
Summary: Pull Request resolved: facebook#35028 **This Diff require a bump in the react-native-codegen (including this [commit](facebook@7680bde)) to work** This diff sets up iOS and Android to pass their platform to the codegen so that we can have platform-specific specs. ## Changelog [General][Added] - Enable platform-specific Codegen Specs Reviewed By: cortinico Differential Revision: D40516395 fbshipit-source-id: 811dc172653237fb7b089f80490929c891e38292
cipolleschi
force-pushed
the
export-D40516395
branch
from
a8f5ef1
to
d279fcc
Compare
|
This pull request was exported from Phabricator. Differential Revision: D40516395 |
|
PR build artifact for d279fcc is ready. |
|
PR build artifact for d279fcc is ready. |
|
This pull request was successfully merged by @cipolleschi in ab7b4d4. When will my fix make it into a release? | Upcoming Releases |
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
Summary: Pull Request resolved: facebook#35028 **This Diff require a bump in the react-native-codegen (including this [commit](facebook@7680bde)) to work** This diff sets up iOS and Android to pass their platform to the codegen so that we can have platform-specific specs. ## Changelog [General][Added] - Enable platform-specific Codegen Specs Reviewed By: cortinico Differential Revision: D40516395 fbshipit-source-id: 0624f0bfb93c90f78131a605a4847e780783bbaf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This Diff require a bump in the react-native-codegen (including this commit) to work
This diff sets up iOS and Android to pass their platform to the codegen so that we can have platform-specific specs.
Changelog
[General][Added] - Enable platform-specific Codegen Specs
Differential Revision: D40516395