RNGP - Add Variant Support #35063
Closed
RNGP - Add Variant Support #35063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This is part of a series of tasks to make the React Native Gradle Plugin (RNGP) variant-aware. Here I'm creating a new task BundleAndHermesCTask that is variant-aware. Historically we had problems with the Bundle and the Hermes task being separated and overriding their own output. Consolidating those two steps in a single one will make it easier to support seaprate variants. I'm going to use this task in a subsequent diff. Changelog: [Internal] [Changed] - RNGP - Introduce the BundleAndHermesCTask Differential Revision: D40633108 fbshipit-source-id: eb5e5eeef2933c4296b1b117f2a9d1035337f1a5
Summary: This is part of a series of tasks to make the React Native Gradle Plugin (RNGP) variant-aware. Here I'm renaming the top level property to enable hermes from `enableHermes` to `hermesEnabled`. We have a bunch of other properties which are called *Enabled. This one was following a different convention. I'm retaining the backward compatibility for users using `project.ext.react.enableHermes` so this is not going to be a breakign change. Changelog: [Internal] [Changed] - RNGP - Top level property enableHermes -> hermesEnabled Differential Revision: D40633109 fbshipit-source-id: 5b6904eebd675a9f6a857dda86237207a46e379c
Summary: This is part of a series of tasks to make the React Native Gradle Plugin (RNGP) variant-aware. Historically we used to enable the codegen only for library modules. This is not working well for apps like RN Tester which don't have library modules but are running the codegen. Therefore I'm introducing the `enableCodegenInApps` that is allowing apps to turn off the codegen if needed. Changelog: [Internal] [Changed] - RNGP - Introduce enableCodegenInApps Differential Revision: D40633106 fbshipit-source-id: beee31eeae370465c88318fcde3ada6699c61ec2
Summary: This is part of a series of tasks to make the React Native Gradle Plugin (RNGP) variant-aware. I'm extending RNGP to do autoconfiguration of dependencies for React Native and Hermes Engine using the Utils classes which were introduced before. Changelog: [Internal] [Changed] - RNGP - Automatically Configure Dependencies for ReactNative & Hermes Differential Revision: https://internalfb.com/D40633487 fbshipit-source-id: 71fc4136974d5b078decdabef0a17090e4da782b
Summary: This is part of a series of tasks to make the React Native Gradle Plugin (RNGP) variant-aware. Here I'm add Variant support to RNGP via the Variant API from AGP 7.x A short summary of changes: - I've pushed a number of breaking changes to ReactExtension (we should document them in the release notes). Specifically I've removed properties which I believe were unnecessary and confusing - I've removed all the extra logic to do the .so cleanups and use the new tasks that use the Artifacts API - I've introduced only a `debuggableVariants` to make all the decisions for the bundling and minification which should be sufficient for users - I've removed all the funcional interfaces are replaced them with lists as they're easy to handle and understand for users. Changelog: [Android] [Changed] - Added Flavor Support to React Native Gradle Plugin (RNGP) Reviewed By: cipolleschi Differential Revision: D40335028 fbshipit-source-id: 483930f71521d7c1ecbc8ab00e05e84bbc11cae8
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D40335028 |
Base commit: 9a87db2 |
|
PR build artifact for f23dbb5 is ready. |
|
PR build artifact for f23dbb5 is ready. |
|
This pull request was successfully merged by @cortinico in 8ad86c7. When will my fix make it into a release? | Upcoming Releases |
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
Summary: Pull Request resolved: facebook#35063 This is part of a series of tasks to make the React Native Gradle Plugin (RNGP) variant-aware. Here I'm add Variant support to RNGP via the Variant API from AGP 7.x A short summary of changes: - I've pushed a number of breaking changes to ReactExtension (we should document them in the release notes). Specifically I've removed properties which I believe were unnecessary and confusing - I've removed all the extra logic to do the .so cleanups and use the new tasks that use the Artifacts API - I've introduced only a `debuggableVariants` to make all the decisions for the bundling and minification which should be sufficient for users - I've removed all the funcional interfaces are replaced them with lists as they're easy to handle and understand for users. Changelog: [Android] [Changed] - Added Flavor Support to React Native Gradle Plugin (RNGP) Reviewed By: cipolleschi Differential Revision: D40335028 fbshipit-source-id: d9ac1437de8a27db2e93df15b13772b221e036b2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This is part of a series of tasks to make the React Native Gradle Plugin (RNGP) variant-aware.
Here I'm add Variant support to RNGP via the Variant API from AGP 7.x
A short summary of changes:
debuggableVariantsto make all the decisions for the bundling and minification which should be sufficient for usersChangelog:
[Android] [Changed] - Added Flavor Support to React Native Gradle Plugin (RNGP)
Reviewed By: cipolleschi
Differential Revision: D40335028