Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the template to load the correct JS engine at runtime. #35095

Closed
wants to merge 1 commit into from
Closed

Update the template to load the correct JS engine at runtime. #35095

wants to merge 1 commit into from

Commits on Oct 26, 2022

  1. Update the template to load the correct JS engine at runtime. (facebo… 

    …ok#35095)

Summary:
Pull Request resolved: facebook#35095

This change will make sure that we load the correct JS engine at runtime,
by using the BuildConfig flag that RNGP sets for us.

This will solve a lot of noise in adb logcat for users seeing
stacktraces mentioning failing to load `jscexecutor` library.

This is also a breaking change, but as the API was not widely used nor
advertised in the template, we should be fine by just mentioning this in the release notes.

Changelog:
[Android] [Changed] - Update the template to load the correct JS engine at runtime

Differential Revision: D40710597

fbshipit-source-id: d47e6c538696428eec591afba53bb65a177ce927
    @cortinico @facebook-github-bot
    cortinico authored and facebook-github-bot committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    71c1faf View commit details
    Browse the repository at this point in the history