feat: Add "option" to available role values #35137
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
70 tasks
react-native-bot
added
the
Type: Enhancement
Base commit: 87c356d |
Base commit: 87c356d |
|
PR build artifact for c01e7f8 is ready. |
jacdebug
approved these changes
Oct 31, 2022
|
@NickGerleman has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
This pull request was successfully merged by @gabrieldonadel in e3e635e. When will my fix make it into a release? | Upcoming Releases |
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
Summary: As pointed out by efoken on facebook#34424 (comment) we forgot we add the `option` value to the `role` prop, so this PR adds this missing value as requested on facebook#34424. ## Changelog [General] [Added] - Add "option" to available role values Pull Request resolved: facebook#35137 Test Plan: Ensure that CI is green as there isn't much to test in this case because we're just adding a value that maps to `undefined` Reviewed By: jacdebug Differential Revision: D40849497 Pulled By: NickGerleman fbshipit-source-id: 5e3e24c0ff05c361a7a8dc1ee1f20ba3fb6988ca
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As pointed out by @efoken on #34424 (comment) we forgot we add the
optionvalue to theroleprop, so this PR adds this missing value as requested on #34424.Changelog
[General] [Added] - Add "option" to available role values
Test Plan
Ensure that CI is green as there isn't much to test in this case because we're just adding a value that maps to
undefined