Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buck, etc. changes that enable persisted, sync settings for DevTools #35163

Closed
wants to merge 1 commit into from

Commits on Nov 1, 2022

  1. Buck, etc. changes that enable persisted, sync settings for DevTools (f…

    …acebook#35163)
    
    Summary:
    Pull Request resolved: facebook#35163
    
    # What
    
    This diff contains all the changes from D40333083 (facebook@0fac981) (aka facebook#34964), **except** the change to `setUpReactDevTools.js`, which actually uses the new files.
    
    # Why
    
    * We want to ship the Buck, C++, etc. changes before the JavaScript changes that depend on those files.
    * Otherwise, apps can fail at startup with the message:
    ```
    `TurboModuleRegistry.getEnforcing(...): '${name}' could not be found. ` +
          'Verify that a module by this name is registered in the native binary.',
    ```
    * Note that this only occurs if you are using a previously-built version of the C++, Obj C, etc. files in RN, but a more recent version of the JavaScript files. If you are building from matching sources, this does not occur.
    * After a few days, we can land the JS files.
    
    ## Changelog
    [General][Added] Add, but don't use, DevTools Settings Manager.
    
    Differential Revision: D40873390
    
    fbshipit-source-id: 4d401f7d0e5051eb25ed984d814d8effd9ad2915
    Robert Balicki authored and facebook-github-bot committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    b89a856 View commit details
    Browse the repository at this point in the history