Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump OSS Android build to SDK 33 #35196

Closed
wants to merge 1 commit into from
Closed

Bump OSS Android build to SDK 33 #35196

wants to merge 1 commit into from

Conversation

makovkastar
Copy link
Contributor

@makovkastar makovkastar commented Nov 3, 2022 •
edited
Loading

Summary:
Changelog:
[Android][Changed] - Bump Android compile and target SDK to 33

Differential Revision: D41007003

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner fb-exported labels Nov 3, 2022
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D41007003

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D41007003

makovkastar added a commit to makovkastar/react-native that referenced this pull request Nov 3, 2022
@makovkastar @facebook-github-bot
Bump OSS Android build to SDK 33 (facebook#35196)
8998539 
Summary:
Pull Request resolved: facebook#35196

Changelog:
[Android][Changed] - Bump Android compile and target SDK to 33

Differential Revision: D41007003

fbshipit-source-id: ced9b8eb71874a1b990377a4dc1efb00ad6ef26c
@react-native-bot react-native-bot added the Platform: Android Android applications. label Nov 3, 2022
@analysis-bot
Copy link

analysis-bot commented Nov 4, 2022 •
edited
Loading

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,070,096 -44
android hermes armeabi-v7a 6,442,235 -49
android hermes x86 7,485,095 -41
android hermes x86_64 7,344,683 -35
android jsc arm64-v8a 8,934,821 -18
android jsc armeabi-v7a 7,668,928 -20
android jsc x86 8,994,874 -12
android jsc x86_64 9,473,808 -17

Base commit: cf37479
Branch: main

@makovkastar makovkastar mentioned this pull request Nov 4, 2022
Merged
@makovkastar
Copy link
Contributor Author

Updating the Docker image in react-native-community/docker-android#185.

@analysis-bot
Copy link

analysis-bot commented Nov 4, 2022 •
edited
Loading

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: cf37479
Branch: main

@pull-bot
Copy link

pull-bot commented Nov 4, 2022

PR build artifact for 8998539 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

@pull-bot
Copy link

pull-bot commented Nov 4, 2022

PR build artifact for 8998539 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D41007003

makovkastar added a commit to makovkastar/react-native that referenced this pull request Nov 7, 2022
@makovkastar @facebook-github-bot
Bump OSS Android build to SDK 33 (facebook#35196)
35b2780 
Summary:
Pull Request resolved: facebook#35196

Changelog:
[Android][Changed] - Bump Android compile and target SDK to 33

Reviewed By: cortinico

Differential Revision: D41007003

fbshipit-source-id: 72f414c2c9fd3abda588a8627edadb61570c4086
@github-actions
Copy link

github-actions bot commented Nov 7, 2022 •
edited
Loading

Warnings
⚠️ 🔒 package.json - Changes were made to package.json. This will require a manual import by a Facebook employee.

Generated by 🚫 dangerJS against 0d3489a

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D41007003

makovkastar added a commit to makovkastar/react-native that referenced this pull request Nov 7, 2022
@makovkastar @facebook-github-bot
Bump OSS Android build to SDK 33 (facebook#35196)
bfbdd23 
Summary:
Pull Request resolved: facebook#35196

Changelog:
[Android][Changed] - Bump Android compile and target SDK to 33

Reviewed By: cortinico

Differential Revision: D41007003

fbshipit-source-id: b33c0c5f79dbb80cdaf7517fdf8116f2e7057ebf
@pull-bot
Copy link

pull-bot commented Nov 7, 2022

PR build artifact for bfbdd23 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

@pull-bot
Copy link

pull-bot commented Nov 7, 2022

PR build artifact for bfbdd23 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

@Adimeme Adimeme mentioned this pull request Nov 8, 2022
Closed
@makovkastar @facebook-github-bot
Bump OSS Android build to SDK 33 (facebook#35196)
0d3489a 
Summary:
Pull Request resolved: facebook#35196

Changelog:
[Android][Changed] - Bump Android compile and target SDK to 33

Reviewed By: cortinico

Differential Revision: D41007003

fbshipit-source-id: 758ccde7c5446e3d232cdce4e12599d554d11aca
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D41007003

@pull-bot
Copy link

pull-bot commented Nov 9, 2022

PR build artifact for 0d3489a is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

@pull-bot
Copy link

pull-bot commented Nov 9, 2022

PR build artifact for 0d3489a is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @makovkastar in 394486e.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Nov 9, 2022
kelset pushed a commit that referenced this pull request Nov 22, 2022
@makovkastar @kelset
Bump OSS Android build to SDK 33 (#35196)
d587e0c 
Summary:
Pull Request resolved: #35196

Changelog:
[Android][Changed] - Bump Android compile and target SDK to 33

Reviewed By: cortinico

Differential Revision: D41007003

fbshipit-source-id: e7866107fdcfafa778faa6c7f31835b8dd15647a
@cipolleschi cipolleschi mentioned this pull request Nov 22, 2022
Merged
@donnygitsome

This comment was marked as off-topic.

Sign in to view
@grahammendick grahammendick mentioned this pull request Dec 19, 2022
Merged
OlimpiaZurek pushed a commit to OlimpiaZurek/react-native that referenced this pull request May 22, 2023
@makovkastar @OlimpiaZurek
Bump OSS Android build to SDK 33 (facebook#35196)
943ad8e 
Summary:
Pull Request resolved: facebook#35196

Changelog:
[Android][Changed] - Bump Android compile and target SDK to 33

Reviewed By: cortinico

Differential Revision: D41007003

fbshipit-source-id: e7866107fdcfafa778faa6c7f31835b8dd15647a
@cipolleschi cipolleschi mentioned this pull request Aug 16, 2023
Merged
@cipolleschi cipolleschi mentioned this pull request Sep 21, 2023
Merged
@cipolleschi cipolleschi mentioned this pull request Oct 11, 2023
Merged
@cipolleschi cipolleschi mentioned this pull request Nov 1, 2023
Merged
This was referenced Jan 8, 2024
Merged
Merged
@cipolleschi cipolleschi mentioned this pull request Mar 6, 2024
Merged
@cipolleschi cipolleschi mentioned this pull request Apr 5, 2024
Closed
@cipolleschi cipolleschi mentioned this pull request Apr 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cortinico cortinico cortinico approved these changes

@hramos hramos Awaiting requested review from hramos

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner Platform: Android Android applications.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@makovkastar @facebook-github-bot @analysis-bot @pull-bot @react-native-bot @donnygitsome @cortinico