Chore: move translateFunctionTypeAnnotation into emitFunction #35287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
Please get rid of |
|
@rshest has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Base commit: 5744b21 |
Base commit: 5744b21 |
|
PR build artifact for 2226b40 is ready. |
rshest
approved these changes
Nov 9, 2022
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
…ok#35287) Summary: Part of facebook#34872 In this PR was moved the translateFunctionTypeAnnotation invocation ([Flow](https://github.com/facebook/react-native/blob/main/packages/react-native-codegen/src/parsers/flow/modules/index.js#L362), [TypeScript](https://github.com/facebook/react-native/blob/main/packages/react-native-codegen/src/parsers/typescript/modules/index.js#L376)) into the emitFunction call so that the case FuntionTypeAnnotation results in a one-liner ## Changelog [Internal] [Changed] - Move the translateFunctionTypeAnnotation invocation into the emitFunction Pull Request resolved: facebook#35287 Test Plan: <img width="266" alt="image" src="https://user-images.githubusercontent.com/18408823/200852605-96c233d9-b524-4b7c-bc41-5543534c296b.png"> Reviewed By: christophpurrer Differential Revision: D41157574 Pulled By: rshest fbshipit-source-id: 21f6fe7dcffd30f4009ca91a6dec81bbd4b0902a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part of #34872
In this PR was moved the translateFunctionTypeAnnotation invocation (Flow, TypeScript) into the emitFunction call so that the case FuntionTypeAnnotation results in a one-liner
Changelog
[Internal] [Changed] - Move the translateFunctionTypeAnnotation invocation into the emitFunction
Test Plan