-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add web compat unit tests and fixes #35316
Closed
Closed
Changes from 22 commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
552b7b9
feat: mapped layout props for view component
mayank-96 83a7b6c
fix: merge conflicts
mayank-96 3e98578
fix: moved map into the view component
mayank-96 9a43211
fix: mapped layout props for text component
mayank-96 656e6f6
fix: mapped layout props for image component
mayank-96 4c6f90f
fix: added layout props typings
mayank-96 57ac1e8
Merge remote-tracking branch 'upstream/main' into feat/mapping-layout…
mayank-96 1c90255
Merge remote-tracking branch 'upstream/main' into feat/mapping-layout…
mayank-96 fbd9b8e
Merge remote-tracking branch 'upstream/main' into feat/mapping-layout…
mayank-96 8d6689a
fix: shifted code to stylesheet dir
mayank-96 fc22eb2
fix: removed mapping from image
mayank-96 6cd3c52
Merge remote-tracking branch 'upstream/main' into feat/mapping-layout…
mayank-96 94d3284
wip
mayank-96 ef2dce7
Merge remote-tracking branch 'upstream/main' into feat/mapping-layout…
mayank-96 006bf1f
feat: added unit tests
mayank-96 b373081
fix: minor change
mayank-96 3300043
fix: requested changes
mayank-96 12b028a
Merge branch 'main' into feat/mapping-layout-props
necolas d47e1ba
Add unit tests for web compat View, Text, TextInput
necolas ce1c390
Merge branch 'main' into logical-style-props-and-tests
necolas 21f6db7
Rename processLayoutProps
necolas dfeb49c
Remove logical styles shim
necolas 6d6eca5
Fix missing 'id' and 'tabIndex' support for TextInput
necolas c60419b
Merge branch 'main' into logical-style-props-and-tests
necolas 06718a6
Merge branch 'main' into logical-style-props-and-tests
necolas File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: we should chose a different way than underscore to avoid shadowing. The ESLint rules special case variables starting with underscore as allowed to be possibly unused, and it is commonly used in the codebase for instance-like variables.