Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Codegen] Extract the parseFile function in the typescript and flow parsers #35318

Closed
wants to merge 11 commits into from
Closed

[Codegen] Extract the parseFile function in the typescript and flow parsers #35318

wants to merge 11 commits into from

Commits on Dec 8, 2022

  1. refactor: only import buildSchema in tests

    @MaeIg
    MaeIg committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    8582e20 View commit details
    Browse the repository at this point in the history

  2. refactor: move parseFile in typescript and flow parsers

    @MaeIg
    MaeIg committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    02ffd12 View commit details
    Browse the repository at this point in the history

  3. refactor: remove buildSchema from parseFile params and import it in p… 

    …arsers
    @MaeIg
    MaeIg committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    c6d43a9 View commit details
    Browse the repository at this point in the history

  4. type: use @flow strict

    @MaeIg
    MaeIg committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    0b72a27 View commit details
    Browse the repository at this point in the history

  5. refactor(flow): pass parser as a param to translateTypeAnnotation and… 

    … other functions that consume it
    @MaeIg
    MaeIg committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    e64de34 View commit details
    Browse the repository at this point in the history

  6. refactor(typescript): pass parser as a param to translateTypeAnnotati… 

    …on and other functions that consume it
    @MaeIg
    MaeIg committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    793fcdd View commit details
    Browse the repository at this point in the history

  7. refactor: remove useless language properties 

    It is already accessible in parser
    @MaeIg
    MaeIg committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    9ba9967 View commit details
    Browse the repository at this point in the history

  8. refactor: pass parser as a param to buildModuleSchema and other funct… 

    …ions that consume it
    @MaeIg
    MaeIg committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    7c59203 View commit details
    Browse the repository at this point in the history

  9. refactor: pass parser as a param to buildSchema and other functions t… 

    …hat consume it
    @MaeIg
    MaeIg committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    f510934 View commit details
    Browse the repository at this point in the history

  10. refactor: move buildSchema into utils file 

    It avoid circular dependencies and it is temporary
It will be moved again in facebook#35158
    @MaeIg
    MaeIg committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    1672d29 View commit details
    Browse the repository at this point in the history

  11. refactor: move buildSchema into its own file 

    At least I tried...
There were still circular dependencies...
(node:58076) Warning: Accessing non-existent property 'getTypes' of module exports inside circular dependency
(node:58076) Warning: Accessing non-existent property 'getValueFromTypes' of module exports inside circular dependency
(node:58076) Warning: Accessing non-existent property 'getValueFromTypes' of module exports inside circular dependency
(node:58076) Warning: Accessing non-existent property 'buildModuleSchema' of module exports inside circular dependency
    @MaeIg
    MaeIg committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    29505f7 View commit details
    Browse the repository at this point in the history