Backport fix copy-hermes-xcode.sh from 0.71-stable #35431
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: `[ -f "$source" ]` was wrong. `man test` reads: > -f file True if file exists and is a regular file. -e file True if file exists (regardless of type). hermes.framework is not a regular file but a directory. `-e` is beter here. Also intermediate destiantion directories are now created if they didn't exist. Changelog: [iOS][Fixed] - Make copy-hermes-xcode.sh more reliable. Reviewed By: robhogan Differential Revision: D41472846 fbshipit-source-id: 6713428800ca08ec59d36bdc06f327d7f0519a4f
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D41472846 |
Base commit: cc311ff |
Base commit: cc311ff |
|
PR build artifact for 0ab1971 is ready. |
|
PR build artifact for 0ab1971 is ready. |
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
Summary: Pull Request resolved: facebook#35431 `[ -f "$source" ]` was wrong. `man test` reads: > -f file True if file exists and is a regular file. -e file True if file exists (regardless of type). hermes.framework is not a regular file but a directory. `-e` is beter here. Also intermediate destiantion directories are now created if they didn't exist. Changelog: [iOS][Fixed] - Make copy-hermes-xcode.sh more reliable. Reviewed By: robhogan Differential Revision: D41472846 fbshipit-source-id: 87de0b48d178ca542299b8e5fa741fdc0570d4e2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
[ -f "$source" ]was wrong.man testreads:hermes.framework is not a regular file but a directory.
-eis beter here.Also intermediate destiantion directories are now created if they didn't exist.
Changelog:
[iOS][Fixed] - Make copy-hermes-xcode.sh more reliable.
Reviewed By: robhogan
Differential Revision: D41472846