Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace folly::Optional with std::optional #35436

Closed
wants to merge 1 commit into from
Closed

Replace folly::Optional with std::optional #35436

wants to merge 1 commit into from

Conversation

christophpurrer
Copy link
Contributor

Summary:
Using std::optional as react-native has been using C++17 for quite some time

changelog: [Internal]

Differential Revision: D41415031

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner fb-exported labels Nov 22, 2022
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D41415031

@analysis-bot
Copy link

analysis-bot commented Nov 22, 2022 •
edited
Loading

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,102,660 -873
android hermes armeabi-v7a 6,471,373 -484
android hermes x86 7,520,833 -335
android hermes x86_64 7,379,499 -555
android jsc arm64-v8a 8,967,652 -707
android jsc armeabi-v7a 7,698,978 -489
android jsc x86 9,030,332 -326
android jsc x86_64 9,507,964 -726

Base commit: a672869
Branch: main

@analysis-bot
Copy link

analysis-bot commented Nov 22, 2022 •
edited
Loading

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: a672869
Branch: main

@pull-bot
Copy link

PR build artifact for 372f96e is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

cortinico
cortinico approved these changes Nov 23, 2022
View reviewed changes
Copy link
Contributor

@cortinico cortinico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome stuff! I've checked the CMake part and the code looks generally fine to me 👍

ReactAndroid/src/main/jni/CMakeLists.txt Outdated
@@ -17,7 +17,7 @@ endif(CCACHE_FOUND)

# Make sure every shared lib includes a .note.gnu.build-id header
add_link_options(-Wl,--build-id)
add_compile_options(-Wall -Werror -std=c++1y)
add_compile_options(-Wall -Werror -std=c++17)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D41415031

christophpurrer added a commit to christophpurrer/react-native-macos that referenced this pull request Nov 24, 2022
@christophpurrer @facebook-github-bot
Replace folly::Optional with std::optional (facebook#35436)
d79d435 
Summary:
Pull Request resolved: facebook#35436

Using std::optional as react-native has been using C++17 for quite some time

changelog: [Internal]

Reviewed By: cortinico

Differential Revision: D41415031

fbshipit-source-id: ea27ff45a0f595098c7a974e507b8493fbb33ebb
@pull-bot
Copy link

PR build artifact for d79d435 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

@christophpurrer @facebook-github-bot
Replace folly::Optional with std::optional (facebook#35436)
0c1ca87 
Summary:
Pull Request resolved: facebook#35436

Using std::optional as react-native has been using C++17 for quite some time

changelog: [Internal]

Reviewed By: cortinico

Differential Revision: D41415031

fbshipit-source-id: 8165a4f1b24c49c58fcb5af59a50f31e96816cc4
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D41415031

@pull-bot
Copy link

PR build artifact for 0c1ca87 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @christophpurrer in 022e22c.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Nov 28, 2022
OlimpiaZurek pushed a commit to OlimpiaZurek/react-native that referenced this pull request May 22, 2023
@christophpurrer @OlimpiaZurek
Replace folly::Optional with std::optional (facebook#35436)
50d0359 
Summary:
Pull Request resolved: facebook#35436

Using std::optional as react-native has been using C++17 for quite some time

changelog: [Internal]

Reviewed By: cortinico

Differential Revision: D41415031

fbshipit-source-id: d786647f64b4f90cf75409109830ae0885460c17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cortinico cortinico cortinico approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@christophpurrer @facebook-github-bot @analysis-bot @pull-bot @react-native-bot @cortinico