Bypass tag check in dry run (#35428) #35470
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
cipolleschi
changed the title
cipolleschi
force-pushed
the
cipolleschi/skip_version_tag_check_in_dry_run
branch
from
e0ddfc8
to
dcf08b3
Compare
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Base commit: f5e5274 |
Base commit: f75b92a |
cipolleschi
force-pushed
the
cipolleschi/skip_version_tag_check_in_dry_run
branch
from
dcf08b3
to
829465a
Compare
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
cipolleschi
force-pushed
the
cipolleschi/skip_version_tag_check_in_dry_run
branch
from
829465a
to
846e460
Compare
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
This pull request was successfully merged by @cipolleschi in 8b8f4f3. When will my fix make it into a release? | Upcoming Releases |
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
Summary: When dry-run in stable branch, the tag already exists. We are bypassing the tag-existence check when in a dry-run to have the CI pass ## Changelog [General] [Fixed] - Bypass tag version check when dry-run Pull Request resolved: facebook#35470 Test Plan: CircleCI It worked for RC1 and RC2 Reviewed By: cortinico Differential Revision: D41529648 Pulled By: cipolleschi fbshipit-source-id: d4d7f5534f86c2cf10b05e0d4cab950e4902d8df
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When dry-run in stable branch, the tag already exists. We are bypassing the tag-existence check when in a dry-run to have the CI pass
Changelog
[General] [Fixed] - Bypass tag version check when dry-run
Test Plan
CircleCI
It worked for RC1 and RC2