Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps, template): remove unnecessary ts eslint deps from template #35527

Closed
wants to merge 1 commit into from

Conversation

kelset
Copy link
Contributor

@kelset kelset commented Dec 1, 2022

Summary

In the new TS template, we have two dependencies (@typescript-eslint/eslint-plugin and @typescript-eslint/parser) that are redundant since they are already dependencies of @react-native-community/eslint-config.

This was raised by @UNIDY2002 at this comment, and then @NickGerleman found the historical reason for it being present in the TS template:

react-native-community/react-native-template-typescript#240 added these to fix another change to alter options of the community config. The underlying issues were later fixed in the community ESLint config, and really should never have been in the template. I removed the config overrides already because I saw they were fixed, so we should also be able to remove the explicit dependencies now too I think.

We also doublechecked with @radko93 that we can proceed with this removal

Changelog

[General] [Fixed] - remove unnecessary ts eslint deps from template

Test Plan

Not much to test, generate a new project the usual way (yarn test-e2e-local -t RNTestProject -p Android or iOS) and check that TS still works.

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Contributor A React Native contributor. p: Microsoft Partner: Microsoft Partner labels Dec 1, 2022
@facebook-github-bot
Copy link
Contributor

@huntie has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Copy link
Contributor

@NickGerleman NickGerleman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need to remove parser and plugin directives from the ESLint config.

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: da4243b
Branch: main

@kelset
Copy link
Contributor Author

kelset commented Dec 1, 2022

(closing this off as @NickGerleman will take care of more comprehensive work around this task)

@kelset kelset closed this Dec 1, 2022
@kelset kelset deleted the kelset/remove-unnecessary-deps branch December 1, 2022 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Contributor A React Native contributor. p: Microsoft Partner: Microsoft Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants