fix(deps, template): remove unnecessary ts eslint deps from template #35527
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In the new TS template, we have two dependencies (
@typescript-eslint/eslint-plugin
and@typescript-eslint/parser
) that are redundant since they are already dependencies of @react-native-community/eslint-config.This was raised by @UNIDY2002 at this comment, and then @NickGerleman found the historical reason for it being present in the TS template:
We also doublechecked with @radko93 that we can proceed with this removal
Changelog
[General] [Fixed] - remove unnecessary ts eslint deps from template
Test Plan
Not much to test, generate a new project the usual way (
yarn test-e2e-local -t RNTestProject -p Android
or iOS) and check that TS still works.