Remove .mk prebuilt file and .mk file generation from codegen #35540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This file is unused now that we rely on RNGP. We should be able to remove it in the next stable release 0.72. In 0.71 we shipped it with a removal warning, and users should not rely on it anymore. Changelog: [Android] [Removed] - Remove the react.gradle file as it's unused fbshipit-source-id: 878724d4cb096535fee578d8e93cec78c57509fd
Summary: We now don't need to generate .mk files anymore, therefore I'm removing this logic from the codegen. In RN 0.72 users should be fully migrated to CMake. Changelog: [Android] [Removed] - Remove .mk prebuilt file and .mk file generation from codegen Reviewed By: rshest Differential Revision: D41654122 fbshipit-source-id: d70aed4a61839eac030dc697750904dcdc6057ca
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D41654122 |
Base commit: 759056b |
Base commit: 759056b |
|
PR build artifact for c5a9147 is ready. |
|
PR build artifact for c5a9147 is ready. |
|
This pull request was successfully merged by @cortinico in 7933dd7. When will my fix make it into a release? | Upcoming Releases |
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
…ok#35540) Summary: Pull Request resolved: facebook#35540 We now don't need to generate .mk files anymore, therefore I'm removing this logic from the codegen. In RN 0.72 users should be fully migrated to CMake. Changelog: [Android] [Removed] - Remove .mk prebuilt file and .mk file generation from codegen Reviewed By: rshest Differential Revision: D41654122 fbshipit-source-id: 3a3c01fa8ab4d48460338e1a9ce2ecbd6df25f47
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
We now don't need to generate .mk files anymore, therefore I'm removing
this logic from the codegen. In RN 0.72 users should be fully migrated
to CMake.
Changelog:
[Android] [Removed] - Remove .mk prebuilt file and .mk file generation from codegen
Reviewed By: rshest
Differential Revision: D41654122