Repair when RCTRedBoxGetEnabled is false , inoperative in RCTExceptio…

[liamxujia]

Summary

Repair when RCTRedBoxGetEnabled is false , the red box will still be on display，It resolve that I send test-pack to QA with Xcode Archive on DEBUG env.

Changelog

[General] [Changed] - Append RCTRedBoxGetEnabled() in RCTExceptionsManager.mm

Test Plan

Xcode Archive on DEBUG env, the red box will be not on display.

[facebook-github-bot]

Hi @nxdm!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	7,104,946	+0
android	hermes	armeabi-v7a	6,474,282	+0
android	hermes	x86	7,523,274	+0
android	hermes	x86_64	7,381,509	+0
android	jsc	arm64-v8a	8,972,558	+0
android	jsc	armeabi-v7a	7,704,250	+0
android	jsc	x86	9,035,046	+0
android	jsc	x86_64	9,512,396	+0

Base commit: 96d6680
Branch: main

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
ios	-	universal	n/a	--

Base commit: 96d6680
Branch: main

[pull-bot]

PR build artifact for 4f5bf74 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

[pull-bot]

PR build artifact for 4f5bf74 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

[facebook-github-bot]

@skinsshark has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[luluwu2032]

Redbox was build to surface unhandled JS errors during development, so it supposed to be available in debug mode, maybe it's not aligned with RCTRedBoxGetEnabled but I think we should keep it and fix the alignment instead.

[facebook-github-bot]

@skinsshark merged this pull request in 2217ea4.