Backport fix: update CircleCI config to use the RN version in Hermes workspace caching #35617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
cortinico
approved these changes
Dec 12, 2022
Base commit: 0f089ea |
|
@dmytrorykun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@dmytrorykun merged this pull request in 65e0f79. |
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
…workspace caching (facebook#35617) Summary: This is a backport of facebook@0edcbc3. It fixes inconsistencies in caching strategies of Hermes tarball and Hermes workspace on CircleCI. ## Changelog [INTERNAL] [FIXED] - Update CircleCI config to use the RN version in Hermes workspace caching. Pull Request resolved: facebook#35617 Test Plan: 1. Create and push a new branch. 2. Change version in. react-native/package.json 3. Push those changes. Before: CircleCI restores cached Hermes workspace for the old version. After: CircleCI creates new workspace for the new version. Reviewed By: cipolleschi Differential Revision: D41970943 Pulled By: dmytrorykun fbshipit-source-id: 7e343b7a8d4b1c5a63016ec53538abe4ad7808cc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a backport of 0edcbc3. It fixes inconsistencies in caching strategies of Hermes tarball and Hermes workspace on CircleCI.
Changelog
[INTERNAL] [FIXED] - Update CircleCI config to use the RN version in Hermes workspace caching.
Test Plan
Before:
CircleCI restores cached Hermes workspace for the old version.
After:
CircleCI creates new workspace for the new version.