Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding togglebutton to attributedstring conversions #35632

Closed
wants to merge 1 commit into from

Conversation

fabOnReact
Copy link
Contributor

Summary

fixes runtime error E/ReactNativeJNI(24576): Unsupported AccessibilityRole value: togglebutton when using togglebutton accessibilityRole with Text. Related fabOnReact@da899c0

Changelog

[GENERAL] [FIXED] - Fixes crash when using togglebutton accessibilityRole with Text

Test Plan

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 13, 2022
@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,777,533 +53
android hermes armeabi-v7a 7,097,203 +61
android hermes x86 8,251,954 +23
android hermes x86_64 8,110,095 +79
android jsc arm64-v8a 8,970,209 +62
android jsc armeabi-v7a 7,703,137 +59
android jsc x86 9,033,926 +30
android jsc x86_64 9,511,521 +83

Base commit: 326109b
Branch: main

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 455ca8c
Branch: main

@pull-bot
Copy link

PR build artifact for fb95946 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

@pull-bot
Copy link

PR build artifact for fb95946 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

@fabOnReact fabOnReact marked this pull request as ready for review December 14, 2022 11:29
@facebook-github-bot
Copy link
Contributor

@rshest has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Jan 5, 2023
@facebook-github-bot
Copy link
Contributor

@rshest merged this pull request in dcc5dbe.

OlimpiaZurek pushed a commit to OlimpiaZurek/react-native that referenced this pull request May 22, 2023
Summary:
fixes runtime error `E/ReactNativeJNI(24576): Unsupported AccessibilityRole value: togglebutton` when using togglebutton accessibilityRole with Text. Related fabOnReact@da899c0

## Changelog

[GENERAL] [FIXED] - Fixes crash when using togglebutton accessibilityRole with Text

Pull Request resolved: facebook#35632

Reviewed By: lunaleaps

Differential Revision: D42360628

Pulled By: rshest

fbshipit-source-id: afca8f540d972e1df0c390b3dff8875f07804e97
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants