Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(CI): prevent the e2e test from running on 0.71 #35681

Merged
merged 1 commit into from
Jan 6, 2023
Merged

fix(CI): prevent the e2e test from running on 0.71 #35681

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -533,8 +533,17 @@ jobs:
- run:
name: "Run Tests: JavaScript Tests"
command: node ./scripts/run-ci-javascript-tests.js --maxWorkers 2
- run_e2e:
platform: js

# When not in 0.XX-stable branch, run e2e tests
- when:
condition:
not:
matches:
pattern: "0.[0-9]{2}-stable"
value: << pipeline.git.branch >>
steps:
- run_e2e:
platform: js
Comment on lines +536 to +546
Copy link
Contributor

@NickGerleman NickGerleman Dec 20, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# When not in 0.XX-stable branch, run e2e tests
- when:
condition:
not:
matches:
pattern: "0.[0-9]{2}-stable"
value: << pipeline.git.branch >>
steps:
- run_e2e:
platform: js

From @ryancat's comments it looks like the test we were wanting to disable might still be running. This change originally came from the main branch to conditionally run on stable branches.

I wonder if << pipeline.git.branch >> might evaluate to the branch a PR comes from or some jazz like that. But if this is only to the single branch we could also just remove everything.

FYI @ryancat, since this change targets a "stable branch" instead of "main", we do not sync it to Phabricator, and this change can be committed directly in GitHub.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NickGerleman the test is still running on this PR because the branch is kelset/filter-e2e-on-071 ;)


# Optionally, run disabled tests
- when:
Expand Down