[LOCAL] fix(cli,metro,babel): bump cli and metro and babel to fix Windows+Metro issue #35786

kelset · 2023-01-06T10:53:37Z

Summary

Local 71 PR to bump necessary packages to address an issue we found on Windows with Metro.

Basically, the issue is as follows (from @robhogan's great report)

Git Bash users on Windows who don't have Watchman installed will experience "Unable to resolve" red boxes, because Metro silently doesn't discover any files. This will affect both new and existing projects with default settings.

This has been addressed via patch release of Metro 0.73.7, which requires a bump of CLI too. So this PR was made react-native-community/cli#1787 that led to this CLI release: https://github.com/react-native-community/cli/releases/tag/v10.1.0

Problem is that if we only bump Metro and CLI to these new versions in 0.71 branch, yarn install gets thrown into an infinite loop that errors out with a OOM error.

The root cause seems to be related to the fact that between 0.73.5 and 0.73.7, babel was bumped to 7.20, as you can see here facebook/metro@v0.73.5...v0.73.7#files_bucket

By doing the minimal amount of babel bumps (we need a more well done babel-deps alignment in main branch), this is addressed and yarn install works correctly. This PR is it.

Opening as a PR and not a straight commit because I want to make sure we can discuss if we want to merge this before 0.71.0 or since it's more work than expected, it'd be better to wait for 0.71.1 when we can test things more carefully.

Changelog

[GENERAL] [CHANGED] - Bump CLI to 10.1.0, Metro to 0.73.7, Babel to ^7.20.0

Test Plan

CI is green.

github-actions · 2023-01-06T10:54:40Z

	Warnings
⚠️	🔒 package.json - Changes were made to package.json. This will require a manual import by a Facebook employee.
⚠️	scripts/run-ci-e2e-tests.js#L22 - scripts/run-ci-e2e-tests.js line 22 – 'rm' is assigned a value but never used. (no-unused-vars)

Generated by 🚫 dangerJS against 24d4e22

huntie

Thanks! As this PR does not target main, we're good to merge directly here without the facebook-github-bot workflow I believe.

robhogan · 2023-01-06T11:05:13Z

As a bit of context on the Babel updates, there is some value there - the update fixes a @babel/parser bug that some people were running into on upgrading RN in an existing project: #34719 (comment)

Problem is that if we only bump Metro and CLI to these new versions in 0.71 branch, yarn install gets thrown into an infinite loop that errors out with a OOM error.

👀!

robhogan · 2023-01-09T14:39:28Z

@cortinico / @cipolleschi I guess the 0.71.0 release is imminent, are we targeting this fix for 0.71.1?

kelset · 2023-01-09T15:19:42Z

@cortinico / @cipolleschi I guess the 0.71.0 release is imminent, are we targeting this fix for 0.71.1?

yeah that's the plan at the moment, since this PR bumps babel too so it needed to be a bit more looked into

motiz88 · 2023-01-09T17:39:39Z

The test_js failure here looks like mostly snapshot changes (due to benign changes in the formatting of Babel's output) plus some issue I don't immediately understand with resolving @babel/preset-flow in a test.

kelset · 2023-01-10T10:27:54Z

The test_js failure here looks like mostly snapshot changes (due to benign changes in the formatting of Babel's output) plus some issue I don't immediately understand with resolving @babel/preset-flow in a test.

remember that this PR is on the 0.71-stable branch, so the fact that CI gets funky is most likely (also) related to that

Summary: While working on facebook/react-native#35786 I noticed some inconsistencies in the versioning for Babel and Flow across the monorepo. So in this PR I wanted to address that so that for 0.72 we'll have the codebase in a more consistent shape. Happy to split in multiple PRs if needed. ## Changelog [GENERAL] [CHANGED] - Bump Babel packages to ^7.20.0 (or closest latest release), bump flow parser to 0.206.0 in a few places that were left out from latest bump X-link: facebook/react-native#35787 Reviewed By: cipolleschi Differential Revision: D42384881 Pulled By: hoxyq fbshipit-source-id: 668de2623494b56867c68e9911a276239554411e

Summary: Pull Request resolved: facebook#987 While working on facebook/react-native#35786 I noticed some inconsistencies in the versioning for Babel and Flow across the monorepo. So in this PR I wanted to address that so that for 0.72 we'll have the codebase in a more consistent shape. Happy to split in multiple PRs if needed. ## Changelog [GENERAL] [CHANGED] - Bump Babel packages to ^7.20.0 (or closest latest release), bump flow parser to 0.206.0 in a few places that were left out from latest bump X-link: facebook/react-native#35787 Test Plan: CI is green. Reviewed By: cipolleschi Differential Revision: D42384881 Pulled By: hoxyq fbshipit-source-id: 73bbe08817f89143ca3bad17e37f8922372797ee

Summary: Pull Request resolved: facebook#987 While working on facebook/react-native#35786 I noticed some inconsistencies in the versioning for Babel and Flow across the monorepo. So in this PR I wanted to address that so that for 0.72 we'll have the codebase in a more consistent shape. Happy to split in multiple PRs if needed. ## Changelog [GENERAL] [CHANGED] - Bump Babel packages to ^7.20.0 (or closest latest release), bump flow parser to 0.206.0 in a few places that were left out from latest bump X-link: facebook/react-native#35787 Test Plan: CI is green. Reviewed By: cipolleschi Differential Revision: D42384881 Pulled By: hoxyq fbshipit-source-id: 7bf82121a6cf76c4f65a3680b32bdd8a06538902

Summary: Pull Request resolved: facebook#987 While working on facebook/react-native#35786 I noticed some inconsistencies in the versioning for Babel and Flow across the monorepo. So in this PR I wanted to address that so that for 0.72 we'll have the codebase in a more consistent shape. Happy to split in multiple PRs if needed. ## Changelog [GENERAL] [CHANGED] - Bump Babel packages to ^7.20.0 (or closest latest release), bump flow parser to 0.206.0 in a few places that were left out from latest bump X-link: facebook/react-native#35787 Test Plan: CI is green. Reviewed By: cipolleschi Differential Revision: D42384881 Pulled By: hoxyq fbshipit-source-id: c3aa02e1f29133b51dd138ec926ef0c73b78cf84

Summary: Pull Request resolved: #987 While working on facebook/react-native#35786 I noticed some inconsistencies in the versioning for Babel and Flow across the monorepo. So in this PR I wanted to address that so that for 0.72 we'll have the codebase in a more consistent shape. Happy to split in multiple PRs if needed. ## Changelog [GENERAL] [CHANGED] - Bump Babel packages to ^7.20.0 (or closest latest release), bump flow parser to 0.206.0 in a few places that were left out from latest bump X-link: facebook/react-native#35787 Test Plan: CI is green. Reviewed By: cipolleschi Differential Revision: D42384881 Pulled By: hoxyq fbshipit-source-id: 21fd43391d12722cf707c3cdbbb36f49c036359d

Summary: X-link: facebook/metro#987 While working on #35786 I noticed some inconsistencies in the versioning for Babel and Flow across the monorepo. So in this PR I wanted to address that so that for 0.72 we'll have the codebase in a more consistent shape. Happy to split in multiple PRs if needed. ## Changelog [GENERAL] [CHANGED] - Bump Babel packages to ^7.20.0 (or closest latest release), bump flow parser to 0.206.0 in a few places that were left out from latest bump Pull Request resolved: #35787 Test Plan: CI is green. Reviewed By: cipolleschi Differential Revision: D42384881 Pulled By: hoxyq fbshipit-source-id: 21fd43391d12722cf707c3cdbbb36f49c036359d

Summary: X-link: facebook/metro#987 While working on facebook#35786 I noticed some inconsistencies in the versioning for Babel and Flow across the monorepo. So in this PR I wanted to address that so that for 0.72 we'll have the codebase in a more consistent shape. Happy to split in multiple PRs if needed. [GENERAL] [CHANGED] - Bump Babel packages to ^7.20.0 (or closest latest release), bump flow parser to 0.206.0 in a few places that were left out from latest bump Pull Request resolved: facebook#35787 Test Plan: CI is green. Reviewed By: cipolleschi Differential Revision: D42384881 Pulled By: hoxyq fbshipit-source-id: 21fd43391d12722cf707c3cdbbb36f49c036359d

Summary: X-link: facebook/metro#987 While working on facebook/react-native#35786 I noticed some inconsistencies in the versioning for Babel and Flow across the monorepo. So in this PR I wanted to address that so that for 0.72 we'll have the codebase in a more consistent shape. Happy to split in multiple PRs if needed. ## Changelog [GENERAL] [CHANGED] - Bump Babel packages to ^7.20.0 (or closest latest release), bump flow parser to 0.206.0 in a few places that were left out from latest bump Pull Request resolved: facebook/react-native#35787 Test Plan: CI is green. Reviewed By: cipolleschi Differential Revision: D42384881 Pulled By: hoxyq fbshipit-source-id: 21fd43391d12722cf707c3cdbbb36f49c036359d Original: facebook/react-native@f10dd3f

Summary: X-link: facebook/metro#987 While working on facebook/react-native#35786 I noticed some inconsistencies in the versioning for Babel and Flow across the monorepo. So in this PR I wanted to address that so that for 0.72 we'll have the codebase in a more consistent shape. Happy to split in multiple PRs if needed. ## Changelog [GENERAL] [CHANGED] - Bump Babel packages to ^7.20.0 (or closest latest release), bump flow parser to 0.206.0 in a few places that were left out from latest bump Pull Request resolved: facebook/react-native#35787 Test Plan: CI is green. Reviewed By: cipolleschi Differential Revision: D42384881 Pulled By: hoxyq fbshipit-source-id: 21fd43391d12722cf707c3cdbbb36f49c036359d Original-Commit: facebook/react-native@f10dd3f

kelset requested a review from mhorowitz as a code owner January 6, 2023 10:53

facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Contributor A React Native contributor. p: Microsoft Partner: Microsoft Partner labels Jan 6, 2023

kelset changed the base branch from main to 0.71-stable January 6, 2023 10:54

huntie approved these changes Jan 6, 2023

View reviewed changes

kelset mentioned this pull request Jan 6, 2023

chore(babel,flow): realign version bumps #35787

Closed

kelset force-pushed the kelset/71-bump-cli-and-metro-and-babel branch from 24d4e22 to 7f59efa Compare January 16, 2023 11:21

This was referenced Jan 16, 2023

RNTester: Setup E2E tests for iOS and Android with Appium, Jest and Cucumber #35824

Closed

fix(scripts): add logic for version scripts to account for local E2E test versioning #35847

Merged

kelset added 4 commits January 17, 2023 11:21

metro bump

575ac31

bump babel in key package.json(s)

5ca92cf

bump cli

ce406d9

pod update for 0.71.0

ec1c1d2

kelset force-pushed the kelset/71-bump-cli-and-metro-and-babel branch from c0a758c to ec1c1d2 Compare January 17, 2023 11:22

fix for eslint

0e02dfa

kelset merged commit df7c92f into 0.71-stable Jan 17, 2023

kelset deleted the kelset/71-bump-cli-and-metro-and-babel branch January 17, 2023 13:52

snyk-bot mentioned this pull request Feb 10, 2023

[Snyk] Upgrade react-native from 0.63.3 to 0.71.1 NOUIY/react-native-macos#975

Open

hoxyq mentioned this pull request May 17, 2023

Fix babel-runtime version #37457

Closed

hoxyq mentioned this pull request May 18, 2023

bump @babel/* packages (#35787) facebook/metro#987

Closed

cipolleschi mentioned this pull request Aug 16, 2023

cipolleschi/add maven polling #39039

Merged

cipolleschi mentioned this pull request Sep 21, 2023

[LOCAL] Copy hermes ruby files to hermes folder in local E2E test #39577

Merged

cipolleschi mentioned this pull request Oct 11, 2023

cipolleschi/fix CI #40793

Merged

cipolleschi mentioned this pull request Nov 1, 2023

[RN][CI]Update node installation on debian (0.71) #41277

Merged

This was referenced Jan 8, 2024

[0.71][RN][General] Migrate boost download url away from JFrog #42177

Merged

[RN][iOS] Fix symbol not found _jump_fcontext with use_frameworks! #42229

Merged

cipolleschi mentioned this pull request Mar 6, 2024

[RN][iOS][0.71] Fix flipper for Xcode 15.3 #43345

Merged

cipolleschi mentioned this pull request Apr 5, 2024

cipolleschi/fix yoga archive 0.71 #43895

Closed

cipolleschi mentioned this pull request Apr 26, 2024

[iOS][Privacy Manifest] Set up privacy manifest for React Native 0.71 #44281

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[LOCAL] fix(cli,metro,babel): bump cli and metro and babel to fix Windows+Metro issue #35786

[LOCAL] fix(cli,metro,babel): bump cli and metro and babel to fix Windows+Metro issue #35786

kelset commented Jan 6, 2023

github-actions bot commented Jan 6, 2023

huntie left a comment

robhogan commented Jan 6, 2023

robhogan commented Jan 9, 2023

kelset commented Jan 9, 2023

motiz88 commented Jan 9, 2023

kelset commented Jan 10, 2023 •

edited

Loading

[LOCAL] fix(cli,metro,babel): bump cli and metro and babel to fix Windows+Metro issue #35786

[LOCAL] fix(cli,metro,babel): bump cli and metro and babel to fix Windows+Metro issue #35786

Conversation

kelset commented Jan 6, 2023

Summary

Changelog

Test Plan

github-actions bot commented Jan 6, 2023

huntie left a comment

Choose a reason for hiding this comment

robhogan commented Jan 6, 2023

robhogan commented Jan 9, 2023

kelset commented Jan 9, 2023

motiz88 commented Jan 9, 2023

kelset commented Jan 10, 2023 • edited Loading

kelset commented Jan 10, 2023 •

edited

Loading