Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

internalize Slider module #35825

Closed
wants to merge 1 commit into from
Closed

internalize Slider module #35825

wants to merge 1 commit into from

Conversation

hoxyq
Copy link
Contributor

@hoxyq hoxyq commented Jan 13, 2023

Summary:
Changelog:
[iOS][Removed] - removed Slider module
[Android][Removed] - removed Slider module

Reviewed By: cortinico

Differential Revision: D42394124

@hoxyq @facebook-github-bot
internalize Slider module
bdc99ec 
Summary:
Changelog:
[iOS][Removed] - removed Slider module
[Android][Removed] - removed Slider module

Reviewed By: cortinico

Differential Revision: D42394124

fbshipit-source-id: 0b6d64a118d4c3d4b6c53237691113b837e3a805
@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner fb-exported labels Jan 13, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D42394124

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,464,829 -28,656
android hermes armeabi-v7a 7,785,575 -27,877
android hermes x86 8,938,312 -29,555
android hermes x86_64 8,796,372 -30,999
android jsc arm64-v8a 9,651,295 -27,816
android jsc armeabi-v7a 8,385,770 -27,048
android jsc x86 9,713,492 -28,724
android jsc x86_64 10,190,671 -30,170

Base commit: 8befb74
Branch: main

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Jan 16, 2023
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 465e937.

OlimpiaZurek pushed a commit to OlimpiaZurek/react-native that referenced this pull request May 22, 2023
@hoxyq @OlimpiaZurek
internalize Slider module (facebook#35825)
c3886b6 
Summary:
Pull Request resolved: facebook#35825

Changelog:
[iOS][Removed] - removed Slider module
[Android][Removed] - removed Slider module

Reviewed By: cortinico

Differential Revision: D42394124

fbshipit-source-id: 92ba3bc50d16996a597148fa2f8178e6bd6d8eb7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner Platform: iOS iOS applications. Type: Removal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hoxyq @facebook-github-bot @analysis-bot @react-native-bot